Problem/Motivation

The "Set canvas" effect only allows to set a transparent/color filled background to the source image. We need an effect to allow specifying another image as background of the source image being processed (aka "Underlay").

Proposed resolution

Provide patch and test coverage.

CommentFileSizeAuthor
#10 2667564-10.patch30.63 KBmondrake
#10 interdiff_9-10.txt2.47 KBmondrake
#9 2667564-8.patch31.1 KBmondrake
#8 interdiff_6-8.txt6.41 KBmondrake
#6 2667564-6.patch28.07 KBmondrake
#6 interdiff_4-6.txt6.67 KBmondrake
#4 2667564-4.patch22.8 KBmondrake

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Title: Allow an image to be set as canvas in the "Set canvas" effect » Add "Background" image effect
Issue summary: View changes

Looked a bit at this, and I think it's better to have a separate image effect to deal with it. The "Set canvas" effect has options for sizing and defining the background color that would be confusing if we try to keep also adding an image as background in the same effect.

What I fancy here is the 'opposite' of the "Watermark" effect - which allows to overlay a selected image on the source one. With "Background" effect, we would overlay the source image on a selected one.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Assigned: Unassigned » mondrake

Working on a patch, assigning.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
Issue tags: +Needs tests
StatusFileSize
new 2667564-4.patch22.8 KB

This patch adds the 'Background' image effect and toolkit operation for GD. Needs ImageMagick operation and tests.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Needs work
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Needs review
Issue tags: -Needs tests
StatusFileSize
new interdiff_4-6.txt6.67 KB
new 2667564-6.patch28.07 KB

Added tests. ImageMagick operation still missing.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Needs work
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff_6-8.txt6.41 KB

Now with ImageMagick operation, too. Ready for review!

mondrake’s picture

mondrake
Location 🇮🇹
commented
StatusFileSize
new 2667564-8.patch31.1 KB
mondrake’s picture

mondrake
Location 🇮🇹
commented
StatusFileSize
new interdiff_9-10.txt2.47 KB
new 2667564-10.patch30.63 KB

Removed @file docblock for traits/classes.

  • mondrake committed 5549039 on 8.x-1.x 
    Issue #2667564 by mondrake: Add "Background" image effect
mondrake’s picture

mondrake
Location 🇮🇹
commented

Same consideration as per #2655044: Add "Text overlay" image effect:

a) we're still in alpha
b) better have this in and address any bugs from reports, than waiting for reviews :(

Committed, now I'll go for alpha2

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.