Problem/Motivation
The "Set canvas" effect only allows to set a transparent/color filled background to the source image. We need an effect to allow specifying another image as background of the source image being processed (aka "Underlay").
Proposed resolution
Provide patch and test coverage.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 2667564-10.patch | 30.63 KB | mondrake |
| #10 | interdiff_9-10.txt | 2.47 KB | mondrake |
| #9 | 2667564-8.patch | 31.1 KB | mondrake |
Comments
Comment #2
mondrakeLooked a bit at this, and I think it's better to have a separate image effect to deal with it. The "Set canvas" effect has options for sizing and defining the background color that would be confusing if we try to keep also adding an image as background in the same effect.
What I fancy here is the 'opposite' of the "Watermark" effect - which allows to overlay a selected image on the source one. With "Background" effect, we would overlay the source image on a selected one.
Comment #3
mondrakeWorking on a patch, assigning.
Comment #4
mondrakeThis patch adds the 'Background' image effect and toolkit operation for GD. Needs ImageMagick operation and tests.
Comment #5
mondrakeComment #6
mondrakeAdded tests. ImageMagick operation still missing.
Comment #7
mondrakeComment #8
mondrakeNow with ImageMagick operation, too. Ready for review!
Comment #9
mondrakeComment #10
mondrakeRemoved @file docblock for traits/classes.
Comment #12
mondrakeSame consideration as per #2655044: Add "Text overlay" image effect:
a) we're still in alpha
b) better have this in and address any bugs from reports, than waiting for reviews :(
Committed, now I'll go for alpha2
Comment #13
mondrake