Currently I need to create a separate watermark image for every size of image styles. There is not other way to do this and keep proportions between the resulting image an the watermark.

Committer: credit @fietserwin on this issue.

CommentFileSizeAuthor
#7 2667184-7.patch9.93 KBmondrake
#7 interdiff_4-7.txt4.66 KBmondrake
#5 2667184-4.patch5.28 KBmondrake

Comments

Lukas von Blarer created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Related issues: +#760438: Resize Overlay / Watermark

I think this was recently done in Imagecache Actions #760438: Resize Overlay / Watermark

luksak’s picture

luksak
he/him
commented

Ah great. Can we port this easily?

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue summary: View changes
Status: Active » Needs review
Issue tags: +Needs tests

That was not that hard, but now this needs tests.

Need to credit @fietserwin on this issue.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Title: Ability to define size of watermark » Scale watermark image with reference to source image
StatusFileSize
new 2667184-4.patch5.28 KB
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Needs work

NW for the tests

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Needs review
Issue tags: -Needs tests
StatusFileSize
new interdiff_4-7.txt4.66 KB
new 2667184-7.patch9.93 KB

Added tests.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue tags: +Media Initiative, +D8Media
luksak’s picture

luksak
he/him
commented
Status: Needs review » Reviewed & tested by the community

Works like a charm.

slashrsm’s picture

slashrsm commented
Status: Reviewed & tested by the community » Fixed

Committed. Thank you all!

  • slashrsm committed 0c52d4b on 8.x-1.x authored by mondrake 
    Issue #2667184 by fietserwin, mondrake, Lukas von Blarer: Scale...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.