Problem/Motivation

There are multiple Invalid placeholders which generate errors such as :

1. User error: Invalid placeholder (!apilink) in string: The API key for your MailChimp account. Get or generate a valid API key at your !apilink.

2. User error: Invalid placeholder (!MailChimp) in string: Select which lists to show on your signup form. You can create additional lists at !MailChimp

Proposed resolution

Fix the above errors by using @ instead of ! which is currently being used.

Remaining tasks

Find out more such occurrences and fix them.

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#8 mailchimp-invalid_placeholders-2666858-8-do-not-test.patch3.09 KBtaherpro
#2 mailchimp-typo-2666858-2.patch3.09 KBtaherpro
mailchimp.png55.11 KBtaherpro

Comments

taherj created an issue. See original summary.

taherpro’s picture

taherpro commented
Assigned: taherpro » Unassigned
Status: Active » Needs review
StatusFileSize
new mailchimp-typo-2666858-2.patch3.09 KB

This patch fixes the above described issue.

Status: Needs review » Needs work

The last submitted patch, 2: mailchimp-typo-2666858-2.patch, failed testing.

The last submitted patch, 2: mailchimp-typo-2666858-2.patch, failed testing.

The last submitted patch, 2: mailchimp-typo-2666858-2.patch, failed testing.

The last submitted patch, 2: mailchimp-typo-2666858-2.patch, failed testing.

The last submitted patch, 2: mailchimp-typo-2666858-2.patch, failed testing.

taherpro’s picture

taherpro commented
StatusFileSize
new mailchimp-invalid_placeholders-2666858-8-do-not-test.patch3.09 KB

Adding a patch which is ignored by the testbot as the tests are giving CI Errors and the tests need to be fixed in a separate issue.

Also renamed the patch to follow drupal standards.

taherpro’s picture

taherpro commented
Status: Needs work » Needs review
MarcRNelson’s picture

MarcRNelson commented
Status: Needs review » Reviewed & tested by the community

#2 Resolves the Invalid placeholder issues (Drupal 8.0.5) PHP 5.6 & MySQL 5.6.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 8: mailchimp-invalid_placeholders-2666858-8-do-not-test.patch, failed testing.

The last submitted patch, 8: mailchimp-invalid_placeholders-2666858-8-do-not-test.patch, failed testing.

The last submitted patch, 8: mailchimp-invalid_placeholders-2666858-8-do-not-test.patch, failed testing.

The last submitted patch, 8: mailchimp-invalid_placeholders-2666858-8-do-not-test.patch, failed testing.

The last submitted patch, 8: mailchimp-invalid_placeholders-2666858-8-do-not-test.patch, failed testing.

  • ruscoe committed 8bf8e58 on 8.x-1.x authored by taherj 
    Issue #2666858 by taherj: Invalid placeholder errors at multiple...
ruscoe’s picture

ruscoe commented
Status: Needs work » Fixed

Thanks for the patch! Committed to the dev branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.