Remove Unnecessary fully qualified name and unused imports in code base.

CommentFileSizeAuthor
#5 remove_unnecessary-2665288-5.patch1.57 KBmarkdorison
#2 2665288-2.patch1.33 KBheykarthikwithu

Comments

heykarthikwithu created an issue. See original summary.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: heykarthikwithu » Unassigned
Status: Active » Needs review
StatusFileSize
new 2665288-2.patch1.33 KB
markdorison’s picture

markdorison
he/him
commented
Status: Needs review » Reviewed & tested by the community
guschilds’s picture

guschilds commented
Status: Reviewed & tested by the community » Needs work

Thanks, heykarthikwithu.

This patch seems to take two different directions. In one file it removes use Drupal\Core\Url; and keeps usage of \Drupal\Core\Url later in the file. In the other file it leaves use Drupal\Core\Url; and later in the file shortens \Drupal\Core\Url to Url. I'd like to remain consistent and take the same approach in all files. Unless this is following a standard?

markdorison’s picture

markdorison
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new remove_unnecessary-2665288-5.patch1.57 KB

  • guschilds committed b005eef on 8.x-1.x 
    Issue #2665288 by heykarthikwithu, markdorison, guschilds: Cleaned up...
guschilds’s picture

guschilds commented
Status: Needs review » Fixed

Thanks, heykarthikwithu and markdorison. I made a few of the same tweaks to other files and have committed the changes to the 8.x-1.x branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.