Closed (fixed)
Project:
Metatag
Version:
8.x-1.x-dev
Component:
Integration with other module
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
5 Feb 2016 at 19:33 UTC
Updated:
23 Mar 2016 at 19:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
damienmckennaThis works, but only in the strictest definition. It needs some work.
Comment #3
damienmckennaThis adds the --base_class, --image and --multiple options, and improves some of the other options by adding their defaults.
Comment #4
damienmckennaIt's now failing with the following:
Comment #5
damienmckennaNo more errors, because I forgot an argument to the generator function call.
Comment #6
damienmckennaOne remaining question - is there a better way to get a boolean from the user than doing this?
Comment #7
damienmckennaThis fixes the tag generator so it includes the 'image' and 'multiple' options.
Comment #10
damienmckennaTrying that again.
Comment #13
damienmckennaWell that's quite silly, it's complaining about the formatting of a twig file because it's invalid PHP code. It's invalid because it's a twig file. Dangit testbot!
Comment #14
damienmckennaFYI I reported the testbot problem: #2663892: Testbot complaining that a twig file contains invalid PHP?
Comment #16
damienmckennaThat's reasonable for now.
Comment #17
mr.baileysThis fixes the missing value for image and the missing base clase in the extends.
Comment #18
damienmckennaA shorter version of the patch in #17.
Comment #20
damienmckennaThanks for spotting those, mr.baileys! Committed.
Comment #21
mr.baileysApologies for the piecemeal patches, just noticed that description is not working on the tag generator, feels overkill to open a new issue for that so piggy-backing on this one.
Comment #22
damienmckennaCommitted. Thanks again.