The DrupalConsole generator is currently not working due to API changes in Console.

CommentFileSizeAuthor
#21 fix_the_drupalconsole-2663650-21.patch536 bytesmr.baileys
#18 metatag-2663650-18.patch1.73 KBDamienMcKenna
#17 fix_the_drupalconsole-2663650-17.patch10.92 KBmr.baileys
#13 metatag-n2663650-13.patch13.36 KBDamienMcKenna
#10 metatag-n2663650-10.patch13.69 KBDamienMcKenna
#7 metatag-n2663650-7-interdiff.txt2.17 KBDamienMcKenna
#7 metatag-n2663650-7.patch13.69 KBDamienMcKenna
#5 metatag-n2663650-5-interdiff.txt649 bytesDamienMcKenna
#5 metatag-n2663650-5.patch13.14 KBDamienMcKenna
#3 metatag-n2663650-3.patch13.13 KBDamienMcKenna
#2 metatag-n2663650-2.patch10.97 KBDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna created an issue. See original summary.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Active » Needs review
FileSize
metatag-n2663650-2.patch10.97 KB

This works, but only in the strictest definition. It needs some work.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
metatag-n2663650-3.patch13.13 KB

This adds the --base_class, --image and --multiple options, and improves some of the other options by adding their defaults.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Needs work

It's now failing with the following:

Fatal error: Call to a member function getPath() on null in phar:///Users/myaccount/.composer/vendor/drupal/console/bin/console/src/Helper/SiteHelper.php on line 178

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
FileSize
metatag-n2663650-5.patch13.14 KB
metatag-n2663650-5-interdiff.txt649 bytes

No more errors, because I forgot an argument to the generator function call.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

One remaining question - is there a better way to get a boolean from the user than doing this?

Whether this meta tag will allow multiple values:
  [0] FALSE
  [1] TRUE
 >
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
metatag-n2663650-7.patch13.69 KB
metatag-n2663650-7-interdiff.txt2.17 KB

This fixes the tag generator so it includes the 'image' and 'multiple' options.

Status: Needs review » Needs work

The last submitted patch, 7: metatag-n2663650-7.patch, failed testing.

The last submitted patch, 7: metatag-n2663650-7.patch, failed testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
FileSize
metatag-n2663650-10.patch13.69 KB

Trying that again.

Status: Needs review » Needs work

The last submitted patch, 10: metatag-n2663650-10.patch, failed testing.

The last submitted patch, 10: metatag-n2663650-10.patch, failed testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
Parent issue: » #2563607: Plan for Metatag 8.x-1.0-beta4 release
FileSize
metatag-n2663650-13.patch13.36 KB

Well that's quite silly, it's complaining about the formatting of a twig file because it's invalid PHP code. It's invalid because it's a twig file. Dangit testbot!

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

FYI I reported the testbot problem: #2663892: Testbot complaining that a twig file contains invalid PHP?

  • DamienMcKenna committed 483f55a on 
    Issue #2663650 by DamienMcKenna: Updated/fixed the DrupalConsole...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed

That's reasonable for now.

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
CreditAttribution: mr.baileys at Calibrate commented
Status: Fixed » Needs review
FileSize
fix_the_drupalconsole-2663650-17.patch10.92 KB

This fixes the missing value for image and the missing base clase in the extends.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
metatag-2663650-18.patch1.73 KB

A shorter version of the patch in #17.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed

Thanks for spotting those, mr.baileys! Committed.

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
CreditAttribution: mr.baileys at Calibrate commented
Status: Fixed » Needs review
FileSize
fix_the_drupalconsole-2663650-21.patch536 bytes

Apologies for the piecemeal patches, just noticed that description is not working on the tag generator, feels overkill to open a new issue for that so piggy-backing on this one.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed

Committed. Thanks again.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.