Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

Status: Active » Needs review
StatusFileSize
new10.97 KB

This works, but only in the strictest definition. It needs some work.

damienmckenna’s picture

StatusFileSize
new13.13 KB

This adds the --base_class, --image and --multiple options, and improves some of the other options by adding their defaults.

damienmckenna’s picture

Status: Needs review » Needs work

It's now failing with the following:

Fatal error: Call to a member function getPath() on null in phar:///Users/myaccount/.composer/vendor/drupal/console/bin/console/src/Helper/SiteHelper.php on line 178

damienmckenna’s picture

Status: Needs work » Needs review
StatusFileSize
new13.14 KB
new649 bytes

No more errors, because I forgot an argument to the generator function call.

damienmckenna’s picture

One remaining question - is there a better way to get a boolean from the user than doing this?

Whether this meta tag will allow multiple values:
  [0] FALSE
  [1] TRUE
 > 
damienmckenna’s picture

StatusFileSize
new13.69 KB
new2.17 KB

This fixes the tag generator so it includes the 'image' and 'multiple' options.

Status: Needs review » Needs work

The last submitted patch, 7: metatag-n2663650-7.patch, failed testing.

The last submitted patch, 7: metatag-n2663650-7.patch, failed testing.

damienmckenna’s picture

Status: Needs work » Needs review
StatusFileSize
new13.69 KB

Trying that again.

Status: Needs review » Needs work

The last submitted patch, 10: metatag-n2663650-10.patch, failed testing.

The last submitted patch, 10: metatag-n2663650-10.patch, failed testing.

damienmckenna’s picture

Status: Needs work » Needs review
Parent issue: » #2563607: Plan for Metatag 8.x-1.0-beta4 release
StatusFileSize
new13.36 KB

Well that's quite silly, it's complaining about the formatting of a twig file because it's invalid PHP code. It's invalid because it's a twig file. Dangit testbot!

damienmckenna’s picture

  • DamienMcKenna committed 483f55a on
    Issue #2663650 by DamienMcKenna: Updated/fixed the DrupalConsole...
damienmckenna’s picture

Status: Needs review » Fixed

That's reasonable for now.

mr.baileys’s picture

Status: Fixed » Needs review
StatusFileSize
new10.92 KB

This fixes the missing value for image and the missing base clase in the extends.

damienmckenna’s picture

StatusFileSize
new1.73 KB

A shorter version of the patch in #17.

damienmckenna’s picture

Status: Needs review » Fixed

Thanks for spotting those, mr.baileys! Committed.

mr.baileys’s picture

Status: Fixed » Needs review
StatusFileSize
new536 bytes

Apologies for the piecemeal patches, just noticed that description is not working on the tag generator, feels overkill to open a new issue for that so piggy-backing on this one.

damienmckenna’s picture

Status: Needs review » Fixed

Committed. Thanks again.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.