Problem/Motivation

Since the mailchimp_signup entity loads on name it would make sense to add an index for it.

Proposed resolution

Add db name index to mailchimp_signup.

CommentFileSizeAuthor
#3 interdiff.txt648 bytesjoelpittet
#3 add_a_database_index-2660176-3.patch1023 bytesjoelpittet
#2 add_a_database_index-2660176-2.patch975 bytesjoelpittet

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review
StatusFileSize
new add_a_database_index-2660176-2.patch975 bytes
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new add_a_database_index-2660176-3.patch1023 bytes
new interdiff.txt648 bytes

Changing the exists to just return a message as core does with it's index additions.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs review » Reviewed & tested by the community

Looks good. Adding index for the table makes totally sense!

ruscoe’s picture

ruscoe commented
Status: Reviewed & tested by the community » Closed (won't fix)

We're going to be ending support for the 7.x-3.x branch due to the upcoming deprecation of the v2.0 MailChimp API. If you'd still like to add this, please feel free to reopen for the 7.x-4.x branch.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Version: 7.x-3.x-dev » 7.x-4.x-dev
Status: Closed (won't fix) » Reviewed & tested by the community

Still applies to 4.x

  • ruscoe committed d694fba on 7.x-4.x authored by joelpittet 
    Issue #2660176 by joelpittet: Add a database index for name on the...
ruscoe’s picture

ruscoe commented
Status: Reviewed & tested by the community » Fixed

Works great, thanks! I just changed the update number.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.