CacheabilityTest doesn't display the tested entities.

When looking at the verbose output of the cacheabilityTest (php core/scripts/run-tests.sh --verbose --color --browser), I noticed that the test does correctly test the headers, however the output isn't displayed on the result so that seemed weird.

CommentFileSizeAuthor
#9 2659868-9--cacheability_test.patch2.32 KBdrunken monkey
#9 2659868-9--cacheability_test--interdiff.txt863 bytesdrunken monkey
#7 2659868-7--cacheability_test.patch1.47 KBdrunken monkey
#7 2659868-7--cacheability_test--interdiff.txt1.26 KBdrunken monkey
#4 Screen Shot 2016-02-18 at 16.47.16.png360.24 KBborisson_
fix-cacheability-test.patch1.05 KBborisson_

Comments

borisson_ created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Active » Needs review
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Needs work

Could you please elaborate? I don't really understand what you want to say with this issue.

Also:

+++ b/src/Tests/CacheabilityTest.php
@@ -42,12 +42,13 @@ class CacheabilityTest extends WebTestBase {
     // Add a test server and index.
     $this->getTestServer();
-    $this->getTestIndex();
+    $this->indexId = 'database_search_index';

Can't we just remove all three lines? Why do we need a dummy test server?

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Issue summary: View changes
StatusFileSize
new Screen Shot 2016-02-18 at 16.47.16.png360.24 KB

We can probably just remove all 3 lines, yes. updated IS.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented

OK, thanks for clarifying!
It's how I would have understood it – but then, shouldn't the new tests fail?

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Issue tags: +Release blocker
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs work » Needs review
StatusFileSize
new 2659868-7--cacheability_test--interdiff.txt1.26 KB
new 2659868-7--cacheability_test.patch1.47 KB

Re-roll and some small adaptions.

Unfortunately, as mentioned before, I currently can't run the functional tests, so I can't tell whether the problem is still there. The new test seemed to say that it wasn't there to begin with, though, which is strange of course.

Joris, could you maybe run this again?
Otherwise, we might have to trick the d.o test bot into giving us the HTML output (if possible).

Status: Needs review » Needs work

The last submitted patch, 7: 2659868-7--cacheability_test.patch, failed testing.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs work » Needs review
StatusFileSize
new 2659868-9--cacheability_test--interdiff.txt863 bytes
new 2659868-9--cacheability_test.patch2.32 KB
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Great job, thanks @drunken monkey!

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Good to hear – committed.
Thanks again for your work here!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.