Comments

Richard15 created an issue. See original summary.

imyaro’s picture

Assigned: Unassigned » imyaro
imyaro’s picture

Ok..
After few discussions I decided to add this workflow:
If user want to add codemirror hightlighting to any field which is not related devel/php page he should specify form (by form_id) and field (field machine name) in the settings form.
So we can apply this library to any form and field which we want to apply.
Please check patch below

imyaro’s picture

Status: Active » Needs review
imyaro’s picture

StatusFileSize
new12.52 KB

Seems my test field is in the patch.. Please check this one:

kala4ek’s picture

Assigned: imyaro » Unassigned
Status: Needs review » Fixed

Committed.

Richard15’s picture

patching file phpx_tools.info
patching file phpx_tools.admin.inc
patch: **** malformed patch at line 79: Index: sites/all/modules/phpx_tools/js/phpx_tools.js

I can't see anything wrong on that line...

kala4ek’s picture

Can not check it now, but try just download dev version.

Richard15’s picture

I downloaded it, here the problems:

1) on "configuration page" I have this error:

Error message
Notice: Undefined offset: 1 in phpx_tools_settings_form_submit() (line 46 of /home/tommasom/public_html/sites/all/modules/phpx_tools/phpx_tools.admin.inc).

2) I added this #id: 'rules-ui-edit-element' but still no highligthing on that form.

3) The "load" action on devel history/saved script doesn't work anymore.
Console shows:

TypeError: Drupal.settings.phpxtools is undefined

I will upload old version meanwhile.

Thanks

kala4ek’s picture

Status: Fixed » Needs work
imyaro’s picture

Status: Needs work » Needs review
StatusFileSize
new12.65 KB

Fixed..

kala4ek’s picture

Status: Needs review » Active

@Richard15 could yow download latest dev release and check, does it ok for you?

Richard15’s picture

StatusFileSize
new78.56 KB

Still no luck...
I had an error in phpx_tools.js

var $scriptName = $('#edit-script-name');
var $load = $('#' + $loadLink.attr('rel') + '-name', $parent);

if ($script_name.length > 0 && $load.length > 0) {
$scriptName.val($load.text());

about $script_name, I modified $scriptName in $script_name but nothing changed.

I add an error about the load of user.css as you can see in the pic.
Is the module working in your environment?

kala4ek’s picture

Status: Active » Needs work
imyaro’s picture

Status: Needs work » Needs review

Hello,
It works OK for me on current dev and stable release.

Richard15’s picture

StatusFileSize
new54.34 KB

Working wonderfully with the last dev, just underline that it's important to put the "name" of form and textarea, no the id how was thinking and did wrong before :)

Thanks again for this useful module!

Regards

Cristian

Richard15’s picture

kala4ek’s picture

Status: Needs review » Needs work

Need to update README file, and I will update project description after.

imyaro’s picture

Status: Needs work » Needs review
StatusFileSize
new1.54 KB

Updated.
I hope it will be enough.

imyaro’s picture

StatusFileSize
new2.18 KB

Readme also updated

  • kala4ek committed 02fd24c on 7.x-1.x authored by zvse
    Issue #2658600 by zvse, Richard15, kala4ek: Integration with Rules
    
kala4ek’s picture

Issue summary: View changes
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.