[Meta] Make module compatible with drupal 8.0.2

Working on it with latest release.

Please review.

When i try to apply this patch i get an error:

error: patch failed: js/time_spent.js:2
error: js/time_spent.js patch does not apply

Tested on Drupal 8.1.3. It's working as required. No errors while applying patch.

How are you applying the patch? I am Using git apply.

Image

Also maybe i have a different copy of the dev module because when i try to apply the patch manually most of the code that is being replace is not in time_spent.js

This is the state of the current time_spent.js i have and it does not have any old callbackURLs code to be replaced.

(function ($, Drupal) {
  Drupal.behaviors.time_spent = {
    attach: function(context, settings) {
      // Detect if is in an iframe, like overlay module.
      var isInIFrame = (window.location != window.parent.location);
      // Initialize the timer.
      var timer = setInterval( time_spent_ajax, (settings.time_spent.timer * 1000));
      // Limit how long the timer will run (in minutes).
      setTimeout(function() {clearInterval(timer);}, drupalSettings.time_spent.limit * 1000 * 60);
      window.parent.enabled = true;
      if(!isInIFrame){
      }
      else{
        // If a page is loaded into a overlay iframe
        // cancel the timespent from the page under overlay.
        window.parent.enabled = false;
      }
      $('#overlay-close').click(function() {
        window.parent.enabled = true;
      });

      /**
       * Send pings to the backend for to update time spent.
       */
      function time_spent_ajax() {
        if(isInIFrame || window.parent.enabled){
          $.ajax({
            type: 'get',
            url: drupalSettings.path.baseUrl + 'js/time_spent/ajax/' + drupalSettings.time_spent.nid + '?token=' + drupalSettings.time_spent.sectoken,
            dataType: 'json',
            data: 'js=1'
          });
        }
      }
    }
  };
})(jQuery, Drupal);

Hi wolfhowling,

This patch is created on Linux. So it might give this warning on Window system. You can ignore it.

Hi @wolfhowling,

I am using the following command to apply patch:
curl https://www.drupal.org/files/issues/meta_make_module-2658042-3_0.patch | git apply

Please see the screenshot attached.

Is there any way to get this committed to this branch or does someone has a copy of this file on GitHub or some where else that i can access cause even when i try with curl i still get an error. Thanks

ScreenShot

Adding Tags