some of the test file has double semicolon at the end of the line ";;".

// Mock the State service.
$memory_state = new State(new KeyValueMemoryFactory());;

$settings = Settings::getAll();
    $request = Request::create('/');;
CommentFileSizeAuthor
#2 remove-double-semicolon-2658006-2.patch4.45 KBmiteshmap

Comments

miteshmap created an issue. See original summary.

miteshmap’s picture

miteshmap
Primary language Gujarati
commented
Status: Active » Needs review
StatusFileSize
new remove-double-semicolon-2658006-2.patch4.45 KB
cilefen’s picture

cilefen commented
Title: Remove Dobule semicolons at the end of line. » Some test files have double semicolons at the end of statements
Category: Task » Bug report
snehi’s picture

snehi commented
Status: Needs review » Reviewed & tested by the community

It works for me
RTBC now.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review

Does this have a DrupalCS rule?

cilefen’s picture

cilefen commented

@catch Evidently it does not.

$ phpcs --standard=Drupal -e|grep Semi
  Squiz.CSS.SemicolonSpacing
  Squiz.WhiteSpace.SemicolonSpacing
$ phpcs --standard=Drupal -e|grep End
  Drupal.Files.EndFileNewline
  Generic.Files.LineEndings
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Needs work

Thanks for checking.

We should create a DrupalCS/coder issue to add that rule, then once it's in (and DrupalCI is running against core) there'll be no way for core to regress. More at https://www.drupal.org/core/scope#coding-standards

Postponing on the DrupalCS rule.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Postponed
naveenvalecha’s picture

naveenvalecha
He/Him
commented

Agree catch with #7 but there is lot of pending work around #1299710: [meta] Automate the coding-standards part of patch review so should not we push these issues in while drupalci will comeup with the support of coding standards

catch’s picture

catch
he/him
Primary language English
commented
Category: Bug report » Task

@naveenvalecha without a CS rule, none of the work in #1299710: [meta] Automate the coding-standards part of patch review will cover the changes in this issue.

naveenvalecha’s picture

naveenvalecha
He/Him
commented

#10
Yup Make sense

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

quietone’s picture

quietone commented
Related issues: +#3041985: Add Generic.CodeAnalysis.EmptyPHPStatement to phpcs rules to prevent empty PHP statements

This was fixed in #3041985: Add Generic.CodeAnalysis.EmptyPHPStatement to phpcs rules to prevent empty PHP statements. Closing as a duplicate.

quietone’s picture

quietone commented
Status: Postponed » Closed (duplicate)

That was supposed to be closed as duplicate.