The documentation @ http://drupal-bootstrap.org/api/bootstrap/starterkits%21less%21README.md... is inacuurate.

It reads:
"Download and extract the latest Bootstrap Framework Source Files into your new sub-theme. After it has been extracted, the folder should read ./subtheme/bootstrap."

This should be changed because...

The latest version of Bootstrap Framework Source Files is v4.0.0-alpha.2
It contains no no less files and is not compatible with Bootstrap (theme) 8.x-3.0-beta2

Bootstrap (theme) 8.x-3.0-beta2 requires v3.3.6 Bootstrap Framework Source Files @ https://github.com/twbs/bootstrap/releases/tag/v3.3.6 which has LESS support.

Thank you

CommentFileSizeAuthor
#6 2657148_6.patch796 bytesmile23

Comments

dadderley created an issue. See original summary.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Title: Documentation points to unsupported version of Bootstrap Framework Source Files » Document Drupal Bootstrap and Bootstrap Framework major version correlation
Version: 8.x-3.0-beta2 » 8.x-3.x-dev
Category: Task » Bug report
Issue tags: +Needs backport to D7
Related issues: +#2311991: [bootstrap][policy] Figure out versioning, +#2613990: Fix documentation for 8.x

The latest version of Bootstrap Framework Source Files is v4.0.0-alpha.2

This isn't entirely true. You're mentioning an alpha release for a new major version.

If anything needs to "change", or rather added, it's that the project's major version (e.g. CORE.x-PROJECT_MAJOR.x) correlates to and supports the latest Bootstrap Framework major version.

For a better explanation, the following is analogous and shows this correlation (even though 8.x-4.x technically does not yet exist and 7.x-4.x has no code in it):

Drupal Bootstrap Bootstrap Framework
7.x-2.x 2.x.x
7.x-3.x 3.x.x
8.x-3.x 3.x.x
7.x-4.x 4.x.x
8.x-4.x 4.x.x

Also, as a side note, almost all current "documentation" for the 8.x branch is inaccurate (referencing 7.x methods/workflow) and is out-of-date, see #2613990: Fix documentation for 8.x.

All patches are welcome, each branch's documentation is located in the ./docs folder.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Related issues: +#2554199: Bootstrap 4
dadderley’s picture

dadderley commented

OK, I stand corrected.
But, as it stands the documentation is misleading.

markhalliwell’s picture

markhalliwell
Primary language English
commented

But, as it stands the documentation is misleading.

Yes, which is why I didn't close the issue.

Again, all patches are welcome, each branch's documentation is located in the ./docs folder.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Active » Needs review
StatusFileSize
new 2657148_6.patch796 bytes

For a while, if you went to http://getbootstrap.com/ and clicked the 'get bootstrap' button at the bottom (ostensibly the 'latest version'), it would give you BS 4.x. They fixed that, but it's still a good idea to make the docs specific here.

Here's a patch against 8.x-3.x-dev that only updates starterkit/less/README.md to tell you which major version to deal with.

  • markcarver committed 4eda5f3 on 8.x-3.x authored by Mile23 
    Issue #2657148 by Mile23: Document Drupal Bootstrap and Bootstrap...

  • markcarver committed a590554 on 7.x-3.x authored by Mile23 
    Issue #2657148 by Mile23: Document Drupal Bootstrap and Bootstrap...
markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs review » Fixed
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Version: 8.x-3.x-dev » 7.x-3.x-dev
Status: Fixed » Needs work

Might be nice to backport...

markhalliwell’s picture

markhalliwell
Primary language English
commented
Version: 7.x-3.x-dev » 8.x-3.0-alpha2
Status: Needs work » Fixed

It was... See the above commits.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

Ah cool. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.