Problem/Motivation

The formattable data items do not show up in LocalTaskItemForm, we have to show them as a text_format element.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#10 interdiff-formattable_data_item-2654062-7-10.txt449 bytesedurenye
#10 formattable_data_item-2654062-10.patch8.49 KBedurenye
#10 formattable_data_item-2654062-10-test_only.patch3.76 KBedurenye
#7 formattable_data_item-2654062-7.patch8.93 KBedurenye
#7 formattable_data_item-2654062-7-test_only.patch3.76 KBedurenye
#5 formattable_data_item-2654062-5.patch3.83 KBedurenye
#5 formattable_data_item-2654062-5-test_only.patch1023 bytesedurenye
#2 formattable_data_item-2654062-2.patch2.83 KBedurenye
#2 formattable_data_item-2654062-2.png52.54 KBedurenye

Comments

edurenye created an issue. See original summary.

edurenye’s picture

edurenye commented
Status: Active » Needs review
StatusFileSize
new formattable_data_item-2654062-2.png52.54 KB
new formattable_data_item-2654062-2.patch2.83 KB

Done, here you can see the result:

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Needs work

That looks pretty well.

+++ b/translators/tmgmt_local/src/Form/LocalTaskItemForm.php
@@ -148,21 +147,41 @@ class LocalTaskItemForm extends ContentEntityForm {
+        elseif (!empty($data[$key]['#max_length'])) {
...
+          $form[$target_key]['translation']['#element_validate'] = ['::validateMaxLength'];

Is this really an else - so the max length is not validated if we have a format?
I would expect that both is possible at the same time.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Issue tags: +Needs tests

OK discussed, will be a followup to check source plugins and support both max length and format at the same time if needed.

Still we need test coverage to check consideration of format.

edurenye’s picture

edurenye commented
Status: Needs work » Needs review
StatusFileSize
new formattable_data_item-2654062-5-test_only.patch1023 bytes
new formattable_data_item-2654062-5.patch3.83 KB

Added the tests, this should fail when adding a translation to the second data item without this fix, would be better to assert ussing class but we can not do that in simpletest until this issue is not finished #2469713: Step 2: Create a JavaScriptTestBase using PhantomJs Driver/Binary.

Should I add a @todo, I think is not necessary if the test_only fails, but not sure.

edurenye’s picture

edurenye commented
Status: Needs review » Needs work

I'll make this test fail.

Created the followup #2654970: Check source length limits on formatted text fields.

edurenye’s picture

edurenye commented
Status: Needs work » Needs review
StatusFileSize
new formattable_data_item-2654062-7-test_only.patch3.76 KB
new formattable_data_item-2654062-7.patch8.93 KB

That was completely wrong, so I fixed and added proper tests.
I'm not sure that now it's ok, because of the force option in the NestedArray::setValue in LocalTaskItem, but without I have some errors.
With this the tests pass and I tested manually and seems that everything is working fine.

The last submitted patch, 7: formattable_data_item-2654062-7-test_only.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 7: formattable_data_item-2654062-7.patch, failed testing.

edurenye’s picture

edurenye commented
Status: Needs work » Needs review
StatusFileSize
new formattable_data_item-2654062-10-test_only.patch3.76 KB
new formattable_data_item-2654062-10.patch8.49 KB
new interdiff-formattable_data_item-2654062-7-10.txt449 bytes

Reverted the change in Data.

The last submitted patch, 10: formattable_data_item-2654062-10-test_only.patch, failed testing.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Fixed

Long live format support! Committed! :-)

  • miro_dietiker committed 1f80723 on 8.x-1.x authored by edurenye 
    Issue #2654062 by edurenye, miro_dietiker: Formattable data item do not...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.