Closed (fixed)
Project:
Translation Management Tool
Version:
8.x-1.x-dev
Component:
Translator: Local
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
19 Jan 2016 at 11:13 UTC
Updated:
1 Mar 2016 at 17:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
edurenye commentedComment #3
edurenye commentedFirst approach solving all those issues listed, still needs more manual testing to see if there something more that we should fix.
Comment #5
edurenye commentedAssigned where already right.
Comment #6
miro_dietikerCommitting these improvements.
Comment #8
miro_dietikerBack to work. I still see views with over lengthy columns:
See: translate with "Word count " and "Item count" and that also affects all local tasks in that area.
Please recheck and provide further updates.
Comment #9
edurenye commentedAll the errors from the discussed list are fixed except one (Also fixed the thing of the previous comment):
Still need to fix button don't change when validating taskitem.
Comment #10
edurenye commentedComment #12
miro_dietikerThe two are almost identical. I would create the item unconditionally and redefine the two lines only in the if().
And there is a similar case below. Each case would result in 5..10 lines less code and better readability.
Comment #13
edurenye commentedI created followups for the form related issues #2654062: Formattable data item do not show up in LocalTaskItemForm and #2654068: Item confirm buttons does not update properly with ajax.
So I reverted those changes here.
Comment #15
edurenye commentedReverted the remove of the footer and opened a followup #2654198: Incoherence between title and content in manage unassigned translation tasks
Comment #17
edurenye commentedWhen we have a cart it first creates the JobItem, and then when we know the target language it creates a job.
So during this time we have a JobItem without a Job and the tests fail.
Fixed it.
Comment #18
miro_dietikerWe should have some more test coverage (with the current process sequence) and check that the progress elements are updated.
Comment #19
edurenye commentedYes, should be enough to delete the cache clear that are in the test, I'll work on that.
Comment #20
miro_dietikerI committed the views label fixes.
The cache changes are not applied and awaiting test coverage.
Comment #22
edurenye commentedResetting the cache make the test fail, so It's not enough.
Comment #23
edurenye commentedI removed unneeded resetCache in the test but the test doesn't fail without the fix however it fails outside the tests.
Some of them I can't remove as I have to load the objects, and also because the cache is not invalidated between job item and task item, not sure but I think we don't need to change this.
I removed the Save after reviewing as was not needed, does nothing as we don't change anything, the confirm button must save it.
But I found there a small error, when formatted it was not correctly saved, so I fixed it.
Comment #25
miro_dietikerIt's still important to cover this submission and know where it redirects. Unsure if it is covered somewhere else already.
Comment #26
miro_dietikerPlease check and report back.
Comment #27
edurenye commentedWe already check it in the line 491:
Rebased and adding a test_only that tests just the cache.
Comment #29
miro_dietikerStill committed. :-)