Remove depreciated methods in code base.

CommentFileSizeAuthor
#8 2653380-8.patch6.51 KBwebflo
#7 interdiff-2653380-5-7.txt669 bytesheykarthikwithu
#7 2653380-7.patch6.85 KBheykarthikwithu
#5 interdiff-2653380-2-5.txt4.55 KBheykarthikwithu
#5 2653380-5.patch6.85 KBheykarthikwithu
#2 2653380-2.patch6.78 KBheykarthikwithu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

heykarthikwithu created an issue. See original summary.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Assigned: heykarthikwithu » Unassigned
Status: Active » Needs review
FileSize
2653380-2.patch6.78 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2653380-2.patch, failed testing.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Assigned: Unassigned » heykarthikwithu

working on this.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Assigned: heykarthikwithu » Unassigned
Status: Needs work » Needs review
FileSize
2653380-5.patch6.85 KB
interdiff-2653380-2-5.txt4.55 KB

rerolled the patch, with fixing the errors found in #3.

webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
Status: Needs review » Needs work

Thanks for working on this. I found a small nitpick in your patch.

+++ b/swiftmailer.module
@@ -43,7 +43,7 @@ function swiftmailer_mail($key, &$message) {
+  $text[] = '<h3>' . t('Dear !user,', array('!user' => $user->getAccountName())) . '</h3>';

I think we should use getDisplayName instead.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Status: Needs work » Needs review
FileSize
2653380-7.patch6.85 KB
interdiff-2653380-5-7.txt669 bytes

getAccountName() will return login name of account.
getDisplayName() will return display name of account.
So usage of getDisplayName() would be better.

changed done as per #6.

webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
FileSize
2653380-8.patch6.51 KB

Rerolled against the current code base.

  • webflo committed e196852 on 8.x-1.x 
    Issue #2653380 by heykarthikwithu, webflo: Remove deprecated methods...
webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
Title: Remove depreciated methods in code base. » Remove deprecated methods in code base.
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.