Problem/Motivation

We want more information like in LocalTasks view.
We should add type, progress, words and maybe changed.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#11 show_progress-2652654-11.png37.85 KBedurenye
#8 interdiff-show_progress-2652654-5-8.txt4.57 KBedurenye
#8 show_progress-2652654-8.patch14.53 KBedurenye
#5 show_progress-2652654-5.patch14.83 KBedurenye
#5 show_progress-2652654-5-test_only.patch4.17 KBedurenye
#3 show_progress-2652654-3.patch10.84 KBedurenye

Comments

edurenye created an issue. See original summary.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Title: Add more information in the Local Task Items view » Show progress information in Local Task Items view

The primary problem here is that progress is not accessible.
And yeah if adding a type helps gaining overview, let's add that too.

edurenye’s picture

edurenye commented
Status: Active » Needs review
StatusFileSize
new show_progress-2652654-3.patch10.84 KB

Not sure about the link in the label, where should go, to the JobItem? Most probably the assigned user will not be able to open the link. So to the content? I'm not sure if make sense, now the label is from the JobItem, not the content. And most important we don't do that in JobItem, so won't be coherent. Maybe I should open a followup to change it everywhere?

Added progress, word_count, type and empty message. We discussed that we don't want to add changed.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Needs work

That looks good, but our tests should also check that each item is present.

Links yeah, are unrelated to this issue and should be consistent.
So you are telling me the content of the row might be inaccessible as long as the user is not assigned to the job?
I'm not so sure about that. One one hand a user thus only sees what he needs to see. But looking at a job content before deciding might be important for some cases.
Might need a permission.
Let's create a separate issue about consistently linking labels with this permission dependency discussion... and skip it here.

edurenye’s picture

edurenye commented
Status: Needs work » Needs review
StatusFileSize
new show_progress-2652654-5-test_only.patch4.17 KB
new show_progress-2652654-5.patch14.83 KB

Added tests and created the followup #2654248: Add links to labels consistently.

The last submitted patch, 5: show_progress-2652654-5-test_only.patch, failed testing.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Needs work 
+++ b/translators/tmgmt_local/src/Tests/LocalTranslatorTest.php
@@ -498,6 +512,11 @@ class LocalTranslatorTest extends TMGMTTestBase {
+    $result = $this->xpath('//*[@id="edit-items"]/div/div/table/tbody/tr[1]/td[2]')[0];
+    $this->assertEqual($result->span, '0/0/1');

How about an assertJobItemProgress($row, $text)?
Example: $this->asserJobItemProgress(2, '0/0/1')

edurenye’s picture

edurenye commented
Status: Needs work » Needs review
StatusFileSize
new show_progress-2652654-8.patch14.53 KB
new interdiff-show_progress-2652654-5-8.txt4.57 KB

Done.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Fixed

Yes this looks nice!

BTW: Are we safe now with invalidating these elements when items change? We previously had issues with progress markers that was cached and not updated. But i think there is a separate issue about that... :-)

edurenye’s picture

edurenye commented
Issue summary: View changes
StatusFileSize
new show_progress-2652654-11.png37.85 KB

Yes, we are fixing the caching here #2652678: Errors in views in local translator.

Here are the visual changes that we did in this issue:

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.