Allowed moderation states should be split

Just looking at the patch, we are now mixing t() and $this->t().

+    $form['allowed_moderation_states_published'] = [
+      '#type' => 'checkboxes',
+      '#title' => t('Allowed moderation states (Published)'),
+      '#description' => t('The allowed published moderation states this content-type can be assigned.'),
+      '#default_value' => $bundle->getThirdPartySetting('workbench_moderation', 'allowed_moderation_states', array_keys($options_published)),
+      '#options' => $options_published,
+      '#required' => TRUE,
+      '#states' => [
+        'visible' => [
+          ':input[name=enable_moderation_state]' => ['checked' => TRUE],
+        ],
+      ],
+    ];
+
+    // This is screwy, but the key of the array needs to be a user-facing string
+    // so we have to fully render the translatable string to a real string, or
+    // else PHP chokes on an object used as an array key.
+    $options = [
+      $this->t('Unpublished')->render() => $options_unpublished,
+      $this->t('Published')->render() => $options_published,
+    ];
+
     $form['default_moderation_state'] = [
       '#type' => 'select',
       '#title' => t('Default moderation state'),
-      '#empty_option' => t('-- Select --'),
       '#options' => $options,
       '#description' => t('Select the moderation state for new content'),
       '#default_value' => $bundle->getThirdPartySetting('workbench_moderation', 'default_moderation_state', 'draft'),

There may be more t() invocations in the form code.

Alright, alright, alright.

++