Add status icons since the UI just shows the number of the state not even a label.

Add tests.

CommentFileSizeAuthor
#8 interdiff-2650860-6-8.txt527 bytesjohnchque
#8 add-state-icons-to-job-items-2650860-8.patch7.67 KBjohnchque
#6 Screenshot from 2016-01-22 10:30:22.png42.68 KBjohnchque
#6 add-state-icons-to-job-items-2650860-6.patch7.68 KBjohnchque
#6 interdiff-2650860-2-6.txt2.72 KBjohnchque
#2 Screenshot from 2016-01-22 09:58:58.png34.88 KBjohnchque
#2 add-state-icons-to-job-items-2650860-2.patch6.7 KBjohnchque

Comments

yongt9412 created an issue. See original summary.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Active » Needs review
StatusFileSize
new add-state-icons-to-job-items-2650860-2.patch6.7 KB
new Screenshot from 2016-01-22 09:58:58.png34.88 KB

Added icons for Job item states. Added screenshot of UI change.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Title: Add status icons to Job Items. » Add state icons to Job Items.

Status: Needs review » Needs work

The last submitted patch, 2: add-state-icons-to-job-items-2650860-2.patch, failed testing.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

As discussed, please swap the icons for "needs review" and "in progress".
All other aspects look nice!

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2650860-2-6.txt2.72 KB
new add-state-icons-to-job-items-2650860-6.patch7.68 KB
new Screenshot from 2016-01-22 10:30:22.png42.68 KB

As discussed, icons have been switched. Added interdiff. Tests fixed.

Status: Needs review » Needs work

The last submitted patch, 6: add-state-icons-to-job-items-2650860-6.patch, failed testing.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Needs work » Needs review
StatusFileSize
new add-state-icons-to-job-items-2650860-8.patch7.67 KB
new interdiff-2650860-6-8.txt527 bytes

Sorry still one test fix needed. It should work now.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Fixed

Yes, awesome. We have fancy icons now for all job elements! :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.