Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
After deleting a node with Metatag enabled as well as i18n_string, I receive the following notice:
Notice: Undefined variable: new_metatags in metatag_metatags_delete_multiple() (line 709 of /[...]/contrib/metatag/metatag.module).
Proposed resolution
The variable is never defined, but I am unsure of the purpose of this code block.
Remaining tasks
- Create a patch
- Review
User interface changes
Deleting an entity with a Metatag with the i18n_string module enable no longer results in notices.
API changes
None
Data model changes
None
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | metatag-n2648804-2.patch | 743 bytes | DamienMcKenna |
Comments
Comment #2
DamienMcKennaThose lines aren't required, for now.
Comment #3
idebr CreditAttribution: idebr at One Shoe commented{i18n_string}even though 'Translate output' is disabled on the settings page of Metatag (admin/config/search/metatags/settings). Is this the intended behavior?{i18n_string}as mentioned in 1. are not removed when the node is deleted. Would you like me to create a followup issue for this?Comment #4
DamienMcKenna@idebr: Please open a new issue for these problems. Thanks.
Comment #5
DamienMcKennaCommitted.
Comment #7
DamienMcKenna