Closed (works as designed)
Project:
Entity Translation
Version:
7.x-1.x-dev
Component:
Base system
Priority:
Major
Category:
Support request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
8 Jan 2016 at 14:53 UTC
Updated:
28 Jun 2016 at 12:32 UTC
Jump to comment: Most recent
Comments
Comment #2
podarokComment #3
plachThanks for your offer, usually before granting co-maintainership some work in the issue queue is required to demonstrate one's familiarity with the module's code. However if you wish we can arrange a trial period, after which full co-maintainership will be granted.
If you are willing to comply with the following best-practices, I will grant you administration access to the issue queue and we can see whether things work :)
https://www.drupal.org/node/363367
In particular:
For the trial period, every time an issue is RTBC please mail me (sorry, I've got a newborn here and Drupal is not my top priority atm :) and I will accept or reject the patch. Once I'm confident it's ok I'll grant you git repo and release management permissions.
Sounds good?
PS: The roadmap for the first stable release is linked in the module home page and you can find it at #1624830: Plan for Entity Translation 7.x-1.0 release.
Comment #4
plachComment #5
podarokHey @plach
Thank for sending me to the co-maintainers docs. I was reading it few years ago and see it is a bit updated since then.
From my side let me write a few words about how we are working.
Almost all best practices we are following with a @sanchiz and maintaining over 140+ modules at a time. I'm going to add him as well to co-mintainers for ability to handle tasks, assigned to me if I'm offline.
I see you need to review our work just for sure, and we have no problems with that. I will pass all patches to you just making sure we understand each other and code can be merged from your side.
About code - we are using http://cibox.tools suite for checking our code by sniffers, linters and manual checking on builds with running tests before releases.
If you have any additional questions, shoot me via contact form or here any time.
Thanks in advance
Comment #6
candelas commented@podarok, now it would be a good moment to collaborate, since plach is working in the module and still a co-maintainer is needed
#1624830: Plan for Entity Translation 7.x-1.0 release
Have a good coding :)
Comment #7
podarokThank you for pointing to the issue
I'll pass information to my team about a needed help
Comment #8
candelas commented:)
As plach says, Thanks for your offer, usually before granting co-maintainership some work in the issue queue is required to demonstrate one's familiarity with the module's code.
He has been working a lot in Drupal 8 and this module will appreciate a lot a co-maintainer... It will be clue for sites that are in a language/languages different than English to upgrade from Drupal 7 to 8.
Could you please, pass also to your team the link to issues that need review? :)
https://www.drupal.org/project/issues/entity_translation?text=&status=8&...
Дякую ;)
Comment #9
plach@podarok:
I'm very sorry, this got out of my radar, another demonstration that ET badly needs a co-maintainer :)
I just granted you and @sanchiz the permission to administer the issue queue. Just mail me every time you'd wish to commit a patch and I will show up ASAP. I guess 2-3 weeks of this regime should be enough to see whether we are satisfied with each other's workflows. After that I will grant you full VCS access, I'd still like to coordinate releases though.
Comment #10
podarokHey platch
Thank you for permissions to maintain issue queue. I guess we were able to maintain it previously.
We had a CodeSprint here in Kyiv past weekend and weren't able to include entity translation into it because of delays in replies and miscommunications.
At codesprint we usually have a lot of Novices and making for them full flow from finding an issue and helping commit it right at the moment.
That helps us to make a good sprints and to involve more new guys into community.
That's why we weren't able to work on entity_translation during sprint, because of bureaucracy is not so good for sprints.
But anyway, all is good. We were able to work on other modules and got a awesome time here in Kyiv.
Thank you for your time.
Comment #11
plachOk, as you prefer, thanks for your offer anyway.
Comment #12
candelas commented@podarok how often do you make sprints?
Maybe next you can collaborate since bureaucracy has finish, don't you?
In Ukrainian language sure that this module will be appreciated :)
Have a nice coding!
Comment #13
podarok@candelas it depends.
I assume we are usually sprinting monthly
Comment #14
candelas commented@podarok, thanks :)
Where can I see when you spring? I can offer to test your easy patches.
By one side, plach is overload but very generous and as you can see in the issue, some of us ask for a beta version and he left Drupal 8 to give us time ;) So the bug in this issue can be forgiven, can't it?
By other side, @plach, as a teacher and a free software lover, if you are a student as the people that podarok offered (the crazy_ukrainian XDDDD), you should be motivated to get patches accepted, don't you think?
So... let's became a bit crazy, although we are not Ukrainian, and facilitate them to became the co-maintainers ;)