Unfortunately, #2574969: Add a Views-like UI for adding fields seems to have left the \Drupal\search_api\Item\Field a bit chaotic, with some redundant code, left-over bits from before, and inconsistent behavior (especially regarding which getters will attempt to load values from the index if necessary).
Let's clean this mess up!

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

Let's see if we actually relied upon any of this …

Status: Needs review » Needs work

The last submitted patch, 2: 2645098-2--clean_up_field_class.patch, failed testing.

The last submitted patch, 2: 2645098-2--clean_up_field_class.patch, failed testing.

borisson_’s picture

I like the changes but the tests don't, let's get those green again.

borisson_’s picture

drunken monkey’s picture

Status: Needs review » Fixed

Huh, interesting. Makes sense, though, I guess. Thanks a lot for solving it!
Committed.

  • drunken monkey committed ab14825 on 8.x-1.x
    Issue #2645098 by drunken monkey, borisson_: Cleaned up the Field class...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.