Bartik: replace the field--name-field-user-picture class with field--name-user-picture in the CSS.

It would be nice to have before and after pictures.

This issue needs screenshots to show that removing the code causes no visual differences to the element it affects.

Hey,
I go with @chi, as no visual difference is observed before and after applying the patch, still I attempt to show with snapshots.

Before applying Patch:

Patch Applied:

$ git apply 2643250-5.patch

hsha20@DLUHSHA2011265 MINGW64 /c/xampp/htdocs/d8 (drupal-select-box-un-styled)
$ git status
On branch drupal-select-box-un-styled
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

        modified:   core/themes/bartik/css/components/field.css
        modified:   core/themes/bartik/css/components/node.css

Untracked files:
  (use "git add <file>..." to include in what will be committed)

        .buildpath
        .project
        .settings/
        2643250-5.patch
        sites/default/files/
        sites/default/settings.php

no changes added to commit (use "git add" and/or "git commit -a")

After patch applied:

Checked for default user image (user_picture) and create custom image field (field_user_image) to capture scenario in snapshots.

Just noticed something in the patch. We shouldn't be removing the section below in the patch as it adds specific styling to the user picture in nodes. These styles are broken at head right now and we need to replace the class in the CSS with what we have in the markup, not remove it entirely.

+++ b/core/themes/bartik/css/components/node.css
@@ -40,15 +40,6 @@
-.node__meta .field--name-field-user-picture img {
-  float: left; /* LTR */
-  margin: 1px 20px 0 0; /* LTR */
-}
-[dir="rtl"] .node__meta .field--name-field-user-picture img {
-  float: right;
-  margin-left: 20px;
-  margin-right: 0;
-}

Please can the above code be put back into the patch plus the class replaced with the current one in the markup... field--name-user-picture.

These styles are needed for the user picture layout in nodes, see below.

Before

After

The patch from #2 does what's asked in #9. Plus it also fixes the naming in the original class instead of removing it altogether. I think that patch should be used instead of creating a new one.

Accordingly, that patch applies cleanly to 8.2.x (commit # 463d844). No visual difference is observed before and after applying the patch as shown in the screenshots below.

Before:

After:

Sweet!

So the patch to be considered for commit is in #2.

Thanks all!!!

Suggested commit message:

git commit -m 'Issue #2643250 by Chi, emma.maria, talhaparacha, Himanshu5050: Bartik: replace the field--name-field-user-picture class with field--name-user-picture in the CSS'

Tested at Drupal Toronto sprint. +1 to RBTC.

Committed d3ef26b (#2) and pushed to 8.2.x. This gets all the cases of the old class name. Thanks!