Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Suggested commit message:
git commit -m 'Issue #2643250 by Chi, emma.maria, talhaparacha, Himanshu5050: Bartik: replace the field--name-field-user-picture class with field--name-user-picture in the CSS'
The referenced class should be field--name-user-picture.
.node__meta .field--name-field-user-picture img {
float: left; /* LTR */
margin: 1px 20px 0 0; /* LTR */
}
Comment | File | Size | Author |
---|---|---|---|
#2 | 2643250-2.patch | 1.01 KB | Chi |
Comments
Comment #2
Chi CreditAttribution: Chi commentedComment #3
Chi CreditAttribution: Chi commentedComment #4
dawehnerIt would be nice to have before and after pictures.
Comment #5
Chi CreditAttribution: Chi commentedThere is no visual difference because that picture also has field--type-image class. I propose removing that classes at all.
Comment #6
emma.mariaThis issue needs screenshots to show that removing the code causes no visual differences to the element it affects.
Comment #7
emma.mariaComment #8
Himanshu5050 CreditAttribution: Himanshu5050 at Publicis Sapient for Publicis Sapient commentedHey,
I go with @chi, as no visual difference is observed before and after applying the patch, still I attempt to show with snapshots.
Before applying Patch:
Patch Applied:
After patch applied:
Checked for default user image (user_picture) and create custom image field (field_user_image) to capture scenario in snapshots.
Comment #9
emma.mariaJust noticed something in the patch. We shouldn't be removing the section below in the patch as it adds specific styling to the user picture in nodes. These styles are broken at head right now and we need to replace the class in the CSS with what we have in the markup, not remove it entirely.
Please can the above code be put back into the patch plus the class replaced with the current one in the markup...
field--name-user-picture
.These styles are needed for the user picture layout in nodes, see below.
Before
After
Comment #10
talhaparacha CreditAttribution: talhaparacha as a volunteer commentedThe patch from #2 does what's asked in #9. Plus it also fixes the naming in the original class instead of removing it altogether. I think that patch should be used instead of creating a new one.
Accordingly, that patch applies cleanly to 8.2.x (commit # 463d844). No visual difference is observed before and after applying the patch as shown in the screenshots below.
Before:
After:
Comment #11
talhaparacha CreditAttribution: talhaparacha as a volunteer commentedComment #12
emma.mariaSweet!
So the patch to be considered for commit is in #2.
Thanks all!!!
Suggested commit message:
git commit -m 'Issue #2643250 by Chi, emma.maria, talhaparacha, Himanshu5050: Bartik: replace the field--name-field-user-picture class with field--name-user-picture in the CSS'
Comment #13
chris.smith CreditAttribution: chris.smith at Portage CyberTech commentedTested at Drupal Toronto sprint. +1 to RBTC.
Comment #14
star-szrCommitted d3ef26b (#2) and pushed to 8.2.x. This gets all the cases of the old class name. Thanks!