Even though RenderedItemTest currently passes without problems, there's actually several things wrong with it:

  • The view mode configuration for users and comments is not in the expected format (it should be keyed by both datasource ID and bundle ID, not just the former, even if there is only one pseudo-bundle).
  • There is a view mdoe setting for the "article" content type, but that content type doesn't even exist.
  • Why is the "Comment" module even included?

Also, the code currently uses short array syntax, which I have otherwise avoided to add in the module, for consistency's sake. (Although at this point we probably could already be consistent the other way round, too.)

When fixing these issues, it would be good to also add tests for the processor's calculateDependencies() and onDependencyRemoval() methods, as introduced in #2574633: Properly react when a plugin's dependencies are removed (at least the latter). And to also maybe add tests for viewing comments and/or users, if we already have those modules included.

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

Status: Active » Needs work
StatusFileSize
new3.66 KB

Here is a WIP, which currently fails because the "teaser" view mode set for comments actually doesn't even exist – there's only "full" by default.

borisson_’s picture

Status: Needs work » Needs review

This makes sense; setting to NR for the bot.

Status: Needs review » Needs work

The last submitted patch, 2: 2642792-2--fix_and_expand_rendered_item_test.patch, failed testing.

The last submitted patch, 2: 2642792-2--fix_and_expand_rendered_item_test.patch, failed testing.

drunken monkey’s picture

Issue tags: +Release blocker
drunken monkey’s picture

Status: Needs work » Needs review
StatusFileSize
new11.77 KB
new11.22 KB

Still not perfect, I skimmed over the comment testing a bit, but still a large improvement, I'd say. (Part of this, namely the dependency testing, has been resolved in the meantime, though.)

borisson_’s picture

Looks good!

borisson_’s picture

Status: Needs review » Reviewed & tested by the community

  • drunken monkey committed bffd8d8 on 8.x-1.x
    Issue #2642792 by drunken monkey: Fixed and expanded the...
drunken monkey’s picture

Status: Reviewed & tested by the community » Fixed

Good to hear, thanks for reviewing!
Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.