I checked the code in the dfp_tag.tpl.php is the plane javascript. Which causes problem if scripts are moved to bottom. Which left variables in tpl file undefined and raise errors.
<script type="text/javascript">
googletag.cmd.push(function() {
googletag.display("<?php print $tag->placeholder_id ?>");
});
</script>
Add that js in the renderable for dfp_tag function. Checked for Blocks causing problem.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2642750-1-removing-inline-js.patch | 951 bytes | pradeep22saini |
Comments
Comment #2
pradeep22saini commentedUpdated the patch to remove inline js and adding that in the renderable array.
Comment #3
bleen commentedBy definition, add tags need to show up inline. I kow that typically you do not want inline js, but this is the exception based on how ad tags work.
Comment #4
alexpottAlso there are features that Google's DFP uses that require the JS goes in
HEAD- for example the ability to download all the ads in a single request.Comment #5
vladimirausThank you for your contributions.
Drupal 7 is no longer supported.
Closing issue as outdated.