The proper signature used to be "function setUp()", then it was changed to "public function setUp()", and now apparently we're supposed to be using "protected function setUp()". I can't find any change notices or documentation which says this, and the example code on drupal.org still shows public, but most of core was changed to protected last year in #2322889: Various setUp() and tearDown() methods are not protected. So let's do this for Ubercart as well.

Comments

TR created an issue. See original summary.

tr’s picture

StatusFileSize
new9.93 KB

Let's add docblocks to these functions while we're at it...

Status: Needs review » Needs work

The last submitted patch, 2: protected-setup-teardown-2.patch, failed testing.

The last submitted patch, 2: protected-setup-teardown-2.patch, failed testing.

tr’s picture

Status: Needs work » Fixed

Fails weren't related to this patch. Committed.

  • TR committed 30ba8f8 on 8.x-4.x
    Issue #2642572 by TR: Make setUp() and tearDown() protected
    
tr’s picture

Component: Code » Tests

  • TR committed 2b5fd56 on 8.x-4.x
    Follow up to [#2642572]
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.