Follow-up to #2314123: Fix various tests:

Various setUp() + tearDown() methods in tests are not declared as protected, changing their visibility to public.

Especially a problem for base test classes, because derived classes suddenly need to define the methods as public, too.

The rule is simple:

  1. Test methods are public.
  2. setUp() and tearDown() are protected.
CommentFileSizeAuthor
test.setup-teardown-visibility.0.patch331.65 KBsun

Comments

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

It only changes or adds access modifier so RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 0463b81 and pushed to 8.0.x. Thanks!

  • alexpott committed 0463b81 on 8.0.x 
    Issue #2322889 by sun: Fixed Various setUp() and tearDown() methods are...

Status: Fixed » Needs work

The last submitted patch, test.setup-teardown-visibility.0.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Fixed

Automated re-test clash.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.