Seems this module needs refactoring to make it with prop to Drupal standards.

CommentFileSizeAuthor
#5 phpx_tools-small_refactoring-2642302-5.patch7.04 KBKovalevich.Artem
#4 small_refactoring-2642302-3.patch7.65 KBimyaro
#2 small_refactoring-2642302-2.patch6 KBimyaro
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Yaroslav Lushnikov created an issue. See original summary.

imyaro’s picture

imyaro CreditAttribution: imyaro as a volunteer and at DrupalJedi commented
FileSize
small_refactoring-2642302-2.patch6 KB

Hello
With this patch it should be better

imyaro’s picture

imyaro CreditAttribution: imyaro as a volunteer and at DrupalJedi commented
Status: Active » Needs review
imyaro’s picture

imyaro CreditAttribution: imyaro as a volunteer and at DrupalJedi commented
FileSize
small_refactoring-2642302-3.patch7.65 KB

Moved load button to separate function and small bug fix

Kovalevich.Artem’s picture

Kovalevich.Artem CreditAttribution: Kovalevich.Artem as a volunteer and at DrupalJedi commented
FileSize
phpx_tools-small_refactoring-2642302-5.patch7.04 KB

Hi. I fixed previous patch, now it is compatible with the latest version of the module.

kala4ek’s picture

kala4ek
Primary language Russian
Location 🇷🇺 Novosibirsk
CreditAttribution: kala4ek as a volunteer and at DrupalJedi commented
Assigned: Unassigned » kala4ek
kala4ek’s picture

kala4ek
Primary language Russian
Location 🇷🇺 Novosibirsk
CreditAttribution: kala4ek as a volunteer and at DrupalJedi commented
Status: Needs review » Fixed

Comitted

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.