Remove depreciated methods and unused imports in code base.

CommentFileSizeAuthor
#26 2639160--18.patch6.51 KBdom.
#19 2639160--17.patch6.53 KBdom.
#16 interdiff-2639160-9-16.txt1.34 KBheykarthikwithu
#16 2639160-16.patch5.68 KBheykarthikwithu
#9 interdiff-2639160-2-9.txt4.95 KBheykarthikwithu
#9 2639160-9.patch6.5 KBheykarthikwithu
#2 2639160-2.patch5.63 KBheykarthikwithu

Comments

heykarthikwithu created an issue. See original summary.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: heykarthikwithu » Unassigned
Status: Active » Needs review
StatusFileSize
new 2639160-2.patch5.63 KB

Removed depreciated methods and unused imports in code base.

Status: Needs review » Needs work

The last submitted patch, 2: 2639160-2.patch, failed testing.

The last submitted patch, 2: 2639160-2.patch, failed testing.

The last submitted patch, 2: 2639160-2.patch, failed testing.

The last submitted patch, 2: 2639160-2.patch, failed testing.

The last submitted patch, 2: 2639160-2.patch, failed testing.

The last submitted patch, 2: 2639160-2.patch, failed testing.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Status: Needs work » Needs review
StatusFileSize
new 2639160-9.patch6.5 KB
new interdiff-2639160-2-9.txt4.95 KB

Status: Needs review » Needs work

The last submitted patch, 9: 2639160-9.patch, failed testing.

The last submitted patch, 9: 2639160-9.patch, failed testing.

The last submitted patch, 9: 2639160-9.patch, failed testing.

The last submitted patch, 9: 2639160-9.patch, failed testing.

The last submitted patch, 9: 2639160-9.patch, failed testing.

The last submitted patch, 9: 2639160-9.patch, failed testing.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Status: Needs work » Needs review
StatusFileSize
new 2639160-16.patch5.68 KB
new interdiff-2639160-9-16.txt1.34 KB

Status: Needs review » Needs work

The last submitted patch, 16: 2639160-16.patch, failed testing.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Status: Needs work » Needs review
dom.’s picture

dom. commented
StatusFileSize
new 2639160--17.patch6.53 KB

Hi !
I will review this both on Drupal 8.0.x and 8.1.x. But already I can say there is two more deprecated methods left in tests: two usages of entity_create() that shoud be removed.

Status: Needs review » Needs work

The last submitted patch, 19: 2639160--17.patch, failed testing.

The last submitted patch, 19: 2639160--17.patch, failed testing.

The last submitted patch, 19: 2639160--17.patch, failed testing.

The last submitted patch, 19: 2639160--17.patch, failed testing.

The last submitted patch, 19: 2639160--17.patch, failed testing.

The last submitted patch, 19: 2639160--17.patch, failed testing.

dom.’s picture

dom. commented
Status: Needs work » Needs review
StatusFileSize
new 2639160--18.patch6.51 KB

Stupid wrong import ! How did I did that ?!

Status: Needs review » Needs work

The last submitted patch, 26: 2639160--18.patch, failed testing.

dom.’s picture

dom. commented
Status: Needs work » Fixed

Patch commited, ignoring tests from PostgreSQL 9.1 because of :
#2641122: PostgreSQL tests often fail with 'The service definition "renderer" does not exist.'
Thanks for the work !

  • Dom. committed 7626b22 on 8.x-1.x 
    Issue #2639160 by heykarthikwithu, Dom.: Remove depreciated methods and...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

chris matthews’s picture

chris matthews commented
Parent issue: » #3093466: Plan for Simplify 8.x-1.1 release