The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Entity module adds the "plural label" property to core entity types. Feeds uses "label plural". Shouldn't it use "plural label" instead?
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | feeds-plural-label-2637118-2.patch | 687 bytes | megachriz |
Comments
Comment #2
megachrizYes, I suppose it would be better to use that, though processors existing in contrib now use "label plural" and on the entity type info there isn't always a "plural label" set. See for example the entity type "commerce_product".
To keep backwards compatibility, I think the best we could do is to check for both.
For reference, this convention was added in #932772: FeedsProcessor: Consolidate process() and clear().
The attached patch checks for "plural label" in entity info. If that property is set, it assigns it to "label plural".
I think that this issue is minor though.
Comment #3
miroslavbanov commentedI agree on issue being minor and needing to check both for BC purposes.
Comment #4
megachrizI tested the code with the Feeds entity processor for "Taxonomy vocabulary entity processor - EXPERIMENTAL". Without the patch applied it says "Update existing taxonomy vocabulary" on the processor settings. With the patch applied it says "Update existing taxonomy vocabularies".
Committed #2.