Entity module adds the "plural label" property to core entity types. Feeds uses "label plural". Shouldn't it use "plural label" instead?

CommentFileSizeAuthor
#2 feeds-plural-label-2637118-2.patch687 bytesmegachriz

Comments

MiroslavBanov created an issue. See original summary.

megachriz’s picture

megachriz
Primary language Dutch
commented
Priority: Normal » Minor
Status: Active » Needs review
StatusFileSize
new feeds-plural-label-2637118-2.patch687 bytes

Yes, I suppose it would be better to use that, though processors existing in contrib now use "label plural" and on the entity type info there isn't always a "plural label" set. See for example the entity type "commerce_product".
To keep backwards compatibility, I think the best we could do is to check for both.
For reference, this convention was added in #932772: FeedsProcessor: Consolidate process() and clear().

The attached patch checks for "plural label" in entity info. If that property is set, it assigns it to "label plural".

I think that this issue is minor though.

miroslavbanov’s picture

miroslavbanov commented

I agree on issue being minor and needing to check both for BC purposes.

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Fixed

I tested the code with the Feeds entity processor for "Taxonomy vocabulary entity processor - EXPERIMENTAL". Without the patch applied it says "Update existing taxonomy vocabulary" on the processor settings. With the patch applied it says "Update existing taxonomy vocabularies".

Committed #2.

  • MegaChriz committed a885a62 on 7.x-2.x 
    Issue #2637118 by MegaChriz: Use "plural label" for "label plural" from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.