Right now, the cancel button is always visible and active. However, initially (until any changes are made), there is nothing to cancel! We should hide it until some changes are made.

CommentFileSizeAuthor
#2 panels-ipe-hide-cancel-button-2636488-2.patch7.69 KBsamuel.mortenson
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dsnopek created an issue. See original summary.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson at Acquia commented
Status: Active » Needs review
FileSize
panels-ipe-hide-cancel-button-2636488-2.patch7.69 KB

This patch adds the ability for Tabs to be hidden, and hides the cancel tab is the App has unsaved changes. The improvements in data modeling will also allow for things like confirmation popups when leaving the page, or other behavioral changes based on an unsaved state.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs review » Reviewed & tested by the community

Manually tested this and it worked quite well for me! The code looks fine, too.

  • samuel.mortenson committed a458d13 on 8.x-3.x 
    Issue #2636488 by samuel.mortenson, phenaproxima: Hide IPE cancel button...
samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson at Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks for the review!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.