Create dropdown widget for facets
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | 2636328-interdiff-9-12.txt | 634 bytes | leksat |
| #12 | widget_dropdown_select-2636328-12.patch | 14.67 KB | leksat |
Create dropdown widget for facets
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | 2636328-interdiff-9-12.txt | 634 bytes | leksat |
| #12 | widget_dropdown_select-2636328-12.patch | 14.67 KB | leksat |
Comments
Comment #2
borisson_With the new
CheckboxWidgetin, work on this should be easier.Comment #3
leksat commentedWorking on this.
Comment #4
leksat commentedHere is a working dropdown.
Some notes:
1. I used URLs as the select option values. That will make possible to use JS to go to URL directly rather than submit form. (I saw this in D7 and found it pretty useful)
2. Dropdown only works well with the show_only_one_result mode enabled. Probably we also need form validation for this.
3. I'm not sure if I will have time to work on this issue or on #2625188: Allow limiting to one active item.
Comment #5
borisson_This looks great, I'll write a unit test and integration test for this as well so we can get this in.
Comment #6
borisson_I have done some work on this, but I don't have enough time now to finish this. I'll come back to this issue later today or tomorrow. Anyway - saving work.
Comment #9
borisson_Tests should be green now.
Comment #10
leksat commentedInteresting, checkbox widget uses form build info to inject and retrieve the facet, but here it works from a constructor. Probably this can be removed?
Comment #11
borisson_I think this way is a little bit cleaner and we should create a followup to make the checkbox look like this one, would you agree?
Comment #12
leksat commentedFound a small bug: user may be redirected to
/_nonepath.Comment #13
leksat commentedCreated a followup for #10: #2681053: Checkboxes widget: facet injected to form in two different ways
Comment #14
borisson_The code here looks great and I think we can commit this and there's a bunch of test coverage added for this. If there are problems with this patch we'll get issues filed for them so we can add specific test coverage for that as well.
Thank you very much for your work on this!