Closed (fixed)
Project:
High contrast
Version:
8.x-1.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
14 Dec 2015 at 16:33 UTC
Updated:
17 Feb 2017 at 08:23 UTC
Jump to comment: Most recent
Comments
Comment #2
hkirsman commentedI'm interested in that too. It's just matter of time!
Comment #3
neograph734I took a stab at this in a sandbox https://www.drupal.org/sandbox/neograph734/2848033 (Check the Version control tab for git cloning instructions). It is nowhere near finished and some functions are still missing or broken, but this is as far as I could get in one day. Currently the block works with the select or radio widgets, injecting a fixed stylesheet.
If others are interested in developing I can grant access to the sandbox. If the module maintainers wants to clone the code to a branch of this module, it is fine with me as well.
Comment #4
hkirsman commentedNice beginning!
Few questions.
1. What should I do after enabling the module and adding the block? For me, site didn't turn to high contrast when I clicked the button in the high contrast block.
2. /admin/config/user-interface/high-contrast is supposed to be empty at the moment?
Comment #5
neograph734I moved most of the configuration from
/admin/config/user-interface/high-contrastto the block configuration page. Allowing different form elements per block (you can have more than one on the page).So
/admin/config/user-interface/high-contrastis intended for changing high contrast logo and hopefully the css.The first option 'links' is not yet working, so you should edit the block and choose radios or select. It should work after that.
Comment #6
neograph734I just pushed some more changes to the repository. All widget types (links, select and radios) appeared to be working now. There is an option to configure some of the colors used in the stylesheet (requires a cache clear for now).
Basically all that's left is the logo and come cleaning up.
Please tell me what you think!
Comment #7
hkirsman commentedSorry for delay. Haven't yet had time to give a second look at it but I liked it already before :) I'll try review it later on today and hopefully merge it with this project if this is ok? If I do this I think it would be right to add you as co-maintainer, Neograph734! ok?
Comment #8
neograph734No problem, I just wanted to make you aware of the additional changes. Feel free to merge the code, your project is a better place for it than my sandbox :)
I'd be happy to maintain it a little!
Comment #10
hkirsman commentedComment #11
hkirsman commentedSorry I didn't understand how to get the correct commit message that would give credit to you :(
Comment #12
neograph734No problem, I didn't do if for the credits ;)
Marking this issue as fixed.
Comment #13
markie commentedCan we get a release for this branch please? at least a dev?
Comment #14
neograph734It is packing now, should show up soon. :)
Comment #15
hkirsman commentedIn the D7 branch I used cookies and js to load the hight contrast css. This was because otherwise caching modules/software could cache the version that has high contrast css included in html. Next user that comes to the site, would then see the high contrast version. Something to add to todo list :)
Comment #16
neograph734@hkirsman I guess it would be good to create a meta issue for all todo's and other issues. I have however spent quite some time to make the module work with Drupal's dynamic page cache. So out of the box it should already be compatible with regular cache. Do'n know about Varnish and other fancy caching solutions though.
Comment #17
hkirsman commentedSeems like a great start already if it works with Drupals dynamic page cache. I'll create an issue - may be there's nothing to fix but at least then it's checked at some point. Boost is not officially available for D8 but there's working version on github. Will check how it works with that.
Comment #18
hkirsman commentedComment #19
hkirsman commented