Problem/Motivation

The ability to add a target to links so they can open in a new tab.

Proposed resolution

Add a target select box to the Atom properties dialog.

User interface changes

Adds a Link Target select list on the Atom properties dialog.

This generates

<a href="http://google.com" target="_blank"><img typeof="foaf:Image" src="http://site.local/sites/default/files/thumbnails/image/image.png" alt="Image.png" title="Image.png"></a>

Remaining tasks

  1. Create a working patch.

I cloned the scald repo, but this patch doesn't apply because there is no scald/modules/library/dnd/plugins directory on the 7.x-1.x branch. Should that portion be patched on the DnD module?

CommentFileSizeAuthor
#7 scald_image_target-2633636-7.patch5.22 KBnagy.balint
#5 scald_image_target-2633636-5.patch3.42 KBtim bozeman
Selection_095.png14.83 KBtim bozeman
scald_target.patch3.7 KBtim bozeman

Comments

Tim Bozeman created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, scald_target.patch, failed testing.

tim bozeman’s picture

tim bozeman commented
jcisio’s picture

jcisio commented

You must have used an old version of Scald when creating the patch. The plugin was moved from DnD to MEE in #2571791: Wysiwyg related plugins and functions should be in the mee module.

tim bozeman’s picture

tim bozeman commented
Status: Needs work » Needs review
StatusFileSize
new scald_image_target-2633636-5.patch3.42 KB

Yes I tried to get away with patching the released version. I rerolled it.

nagy.balint’s picture

nagy.balint commented
Status: Needs review » Needs work

Thanks for the patch!

This should also be added to the scald_image.js, so it appears in the dndck4 plugin.

nagy.balint’s picture

nagy.balint commented
Status: Needs work » Needs review
StatusFileSize
new scald_image_target-2633636-7.patch5.22 KB

Here is the new patch based on #6

Works for me on dndck4.

tim bozeman’s picture

tim bozeman commented
Status: Needs review » Reviewed & tested by the community

Nice!

nagy.balint’s picture

nagy.balint commented
Status: Reviewed & tested by the community » Fixed

Thanks! Committed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.