Coding standards Clean Up

CommentFileSizeAuthor
#2 2632442-2.patch3.64 KBheykarthikwithu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

heykarthikwithu created an issue. See original summary.

heykarthikwithu’s picture

Assigned: heykarthikwithu » Unassigned
Status: Active » Needs review
FileSize
3.64 KB

1. $uid = $user->id();, is not used in the further code.
2. made changes for few misspells.

3. _autologout_get_user_timeout(); is getting the user timeout, but the user time out is not been used in the code base.

/**
 * Adds a field to user/edit to change that users logout.
 */
function autologout_form_user_form_alter(&$form, FormStateInterface $form_state) {
  $user_timeout = _autologout_get_user_timeout();

4. similar to 3 point, $route is not been used in the further code base.

/**
 * Implements hook_autologout_refresh_only().
 */
function autologout_autologout_refresh_only() {
  $url = Url::fromRoute('<current>');
  $route = explode('/', $url->toString());

Status: Needs review » Needs work

The last submitted patch, 2: 2632442-2.patch, failed testing.

heykarthikwithu’s picture

Status: Needs work » Needs review
shahinam’s picture

Here is the update PR for this - https://github.com/ajitdev/autologout/pull/22

  • shahinam committed 36be57b on 8.x-1.x
    Issue #2632442: Fixed typos, improved inline documentation, and cleaned...
  • AjitS committed ac976bb on 8.x-1.x
    Merge pull request #22 from shahinam/Issue-2632442-code-cleanup
    
    Issue #...
AjitS’s picture

Status: Needs review » Fixed

Committed and pushed to 8.x-1.x.
Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

AjitS’s picture