Clean up for Coding standards and Documention

CommentFileSizeAuthor
#17 2632358-17.patch1.35 KBxaiwant
#11 2632358-11.patch3.06 KBxaiwant
#6 2632358-6.patch520 bytesxaiwant
#2 2632358-2.patch2.62 KBharika gujjula

Comments

harika gujjula created an issue. See original summary.

harika gujjula’s picture

harika gujjula commented
Status: Active » Needs review
StatusFileSize
new 2632358-2.patch2.62 KB

Adding Patch.

krknth’s picture

krknth commented
Assigned: harika gujjula » heykarthikwithu
Status: Needs review » Reviewed & tested by the community

It looks good to me.

@karthik : pls check & commit.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: heykarthikwithu » Unassigned
Status: Reviewed & tested by the community » Needs work

@harika gujjula looks good :)
few more code changes can be done as per drupal coding standard.
refer this link http://pareview.sh/pareview/httpgitdrupalorgprojectusernamepolicygit-7x-1x

harika gujjula’s picture

harika gujjula commented

I have generated patch for 7.x-2.x.
http://pareview.sh/pareview/httpgitdrupalorgprojectusernamepolicygit-7x-2x

xaiwant’s picture

xaiwant commented
Assigned: Unassigned » heykarthikwithu
Status: Needs work » Needs review
StatusFileSize
new 2632358-6.patch520 bytes

followed
http://pareview.sh/pareview/httpgitdrupalorgprojectusernamepolicygit-7x-2x

moving to need Review.

Status: Needs review » Needs work

The last submitted patch, 6: 2632358-6.patch, failed testing.

The last submitted patch, 6: 2632358-6.patch, failed testing.

The last submitted patch, 6: 2632358-6.patch, failed testing.

The last submitted patch, 6: 2632358-6.patch, failed testing.

xaiwant’s picture

xaiwant commented
Status: Needs work » Needs review
StatusFileSize
new 2632358-11.patch3.06 KB

updated patch for 7.x-1.x branch.
Needs Review

Status: Needs review » Needs work

The last submitted patch, 11: 2632358-11.patch, failed testing.

The last submitted patch, 11: 2632358-11.patch, failed testing.

The last submitted patch, 11: 2632358-11.patch, failed testing.

The last submitted patch, 11: 2632358-11.patch, failed testing.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
xaiwant’s picture

xaiwant commented
Status: Needs work » Needs review
StatusFileSize
new 2632358-17.patch1.35 KB

updated the patch

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: heykarthikwithu » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.