Rendered entity views field handler

Given semantic versioning this won't land in 8.0.x but just in 8.1.x

1. +++ b/core/modules/views/src/Plugin/views/field/RenderedEntity.php
   @@ -0,0 +1,158 @@
   +/**
   + * Provides an area handler which renders an entity in a certain view mode.
   

   ... field handler

2. +++ b/core/modules/views/src/Plugin/views/field/RenderedEntity.php
   @@ -0,0 +1,158 @@
   +  protected function getEntityManager() {
   +    return $this->entityManager;
   

   There should be a more specific service available now.

3. +++ b/core/modules/views/src/Plugin/views/field/RenderedEntity.php
   @@ -0,0 +1,158 @@
   +
   +  /**
   +   * {@inheritdoc}
   +   */
   +  protected function getLanguageManager() {
   +    return $this->languageManager;
   

   Unused

4. +++ b/core/modules/views/src/Plugin/views/field/RenderedEntity.php
   @@ -0,0 +1,158 @@
   +  /**
   +   * {@inheritdoc}
   +   */
   +  protected function getView() {
   +    return $this->view;
   +  }
   

   That method is not used

2. I'm implementing here \Drupal\views\Entity\Render\EntityTranslationRenderTrait::getEntityManager() which should return a \Drupal\Core\Entity\EntityManagerInterface. Until it's not fixed there I can't really do anything about it.
3-4: I need to implement these too because they are abstract methods of \Drupal\views\Entity\Render\EntityTranslationRenderTrait.

Oh yeah you are right,

+++ b/core/modules/views/src/Tests/Handler/FieldRenderedEntityTest.php
@@ -0,0 +1,156 @@
+    $edit = array(
+      'id' => 'foobar',
+      'label' => t('My view mode'),
+    );
+    $this->drupalPostForm('admin/structure/display-modes/view/add/node', $edit, t('Save'));
+
...
+    // Foobar view mode should be custom.
+    $edit = [
+      'display_modes_custom[foobar]' => 1,
+    ];
+    $this->drupalPostForm('admin/structure/types/manage/article/display', $edit, t('Save'));
+    $this->drupalPostForm('admin/structure/types/manage/page/display', $edit, t('Save'));
...
+    // Hide the body on the foobar view mode.
+    $edit = [
+      'fields[body][type]' => 'hidden',
+    ];
+    $this->drupalPostForm('admin/structure/types/manage/article/display/foobar', $edit, t('Save'));
+    $this->drupalPostForm('admin/structure/types/manage/page/display/foobar', $edit, t('Save'));
...
+    // Show the body on the foobar view mode.
+    $edit = [
+      'fields[body][type]' => 'text_default',
+    ];
+    $this->drupalPostForm('admin/structure/types/manage/article/display/foobar', $edit, t('Save'));
+    $this->drupalPostForm('admin/structure/types/manage/page/display/foobar', $edit, t('Save'));

IMHO we could use the API directly, so using EntityViewMode::create()->save() and EntityViewDisplay::create()->save().

Its just unnecessary HTTP requests without any benefit, IMHO

Given that people might want to use it in 8.0.x already, we backported it to https://github.com/fago/entity/pull/19

I think this is ready other then this minor feedback.

+++ b/core/modules/views/src/Plugin/views/field/RenderedEntity.php
@@ -0,0 +1,159 @@
+  /**
+   * {@inheritdoc}
+   */
+  protected function getView() {
+    return $this->view;
+  }

AFAICS we are not using this method so this can be removed.

I want to try and convert that test to a kernel one, for speed.

Thank you @bojanz!!

Here's my attempt at porting it to ViewKernelTestBase

Converted the test to use entity_test entities, and some more changes.

We're good to go.

Made some final code style tweaks.

Actually the test had unused imports.

The calculateDependencies part was requested by dawehner. Fixed a few comments along the way.

Now really RTBC?

+++ b/core/modules/views/src/Plugin/views/field/RenderedEntity.php
@@ -0,0 +1,207 @@
+      $view_builder = $this->entityManager->getViewBuilder($this->getEntityTypeId());

Why not use $entity->getEntityTypeId() instead of $this->getEntityTypeId()?

I'm okay with that, but the testbot isn't.

Bah.

Ha, I'm confused because there is also getEntityType() on there.

Yeah nevermind the trait adds this.

I think we should add some more test coverage...

• make sure that the correct translations are displayed
• Cache tags merge correctly
• And config dependency added

+++ b/core/modules/views/src/Plugin/views/field/RenderedEntity.php
@@ -0,0 +1,207 @@
+  /**
+   * {@inheritdoc}
+   */
+  public function getCacheMaxAge() {
+    return 0;
+  }

So these views are uncacheable?

I can Confirm the patch working.
"Uncachable" sounds like a very bad Idea. Didn't check that yet.

But I consider this a an essential feature of views as everybody should use viemodes as much as possible (think about your themers ;) ).
It will also enable e.g. Table layout with rendered entities.
So I hope It will be ready in 8.3.

I would like to test this manually, but I'm not sure how to manually test the fact that the rendered entity is being cached.

Tested on Drupal VDD with Drupal 8-1.x

Works as expected. Cache entries are created in cache table (tag based). --> Seems to work :)

We looked at this in the Frankfurt sprint.

+++ b/core/modules/views/src/Plugin/views/field/RenderedEntity.php
@@ -0,0 +1,208 @@
+    if (isset($entity) && $entity->access('view')) {
+      $view_builder = $this->entityManager->getViewBuilder($this->getEntityTypeId());
+      return $view_builder->view($entity, $this->options['view_mode']);
+    }
+    return [];

IMHO we should set #access to $entity->access('view', NULL, TRUE);

@czigor Did you managed to add some translation / cache-tags tests?

Alright, I'll give it a try. Thanks you for your really quick response.

I think we need an empty update hook to clear the views data cache.

True, I guess. On the other hand, nothing is broken without it. The new feature will just appear at some point ;)

Sure, here it is.

I've tested patch #41 on locally.
It seems working fine. Content is also rendered in proper display format. Screenshot attached.

Weird, it applies with fuzz locally. Here's a reroll anyway.

Now with less trash.

mglaman caught the duplicate update number.

Back to RTBC.

1. +++ b/core/modules/views/src/Tests/Handler/FieldRenderedEntityTest.php
   @@ -0,0 +1,209 @@
   +    $role->grantPermission('bypass node access');
   

   Can't imagine this is necessary for entity_test.

2. +++ b/core/modules/views/src/Tests/Handler/FieldRenderedEntityTest.php
   @@ -0,0 +1,209 @@
   +    // The view should not display the body field.
   

   Copy/paste comments - no nodes or body?

3. +++ b/core/modules/views/src/Tests/Handler/FieldRenderedEntityTest.php
   @@ -0,0 +1,209 @@
   +  /**
   +   * Tests the rendered entity output with the body field configured to show.
   +   */
   +  public function testRenderedEntityWithField() {
   +    \Drupal::currentUser()->setAccount($this->user);
   +
   +    // Show the body on the node.x.foobar view mode.
   +    EntityViewDisplay::load('entity_test.entity_test.foobar')->setComponent('test_field', ['type' => 'string', 'label' => 'above'])->save();
   +
   +    // The view should display the body field.
   

   Also copy/paste comments?

Oh yeah , there we go.

Sorry about that, catch.

#54 addresses #53, a search shows no more mentions of "node". Let's give it another shot.

That's better. Committed/pushed to 8.1.x, thanks!

Oh that's funny, I have created a module for that 4 months ago - well done guys :)