Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Unnessary fully qualified name \Drupal\uc_order\Entity\Order in CheckoutController.php
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | interdiff-2630992-2-6.txt | 19.91 KB | heykarthikwithu |
| #6 | 2630992-6.patch | 21.97 KB | heykarthikwithu |
| #2 | 2630992-2.patch | 1.39 KB | heykarthikwithu |
Comments
Comment #2
heykarthikwithu1. Removed unnecessary fully qualified name \Drupal\uc_order\Entity\Order.
2. Replaced the \Drupal::entityManager() with \Drupal::entityTypeManager().
Comment #3
longwaveI think there are several fully qualified names in the codebase that are not strictly necessary (we should use "use" statements instead), it would be good to get them all at once if you can?
Comment #4
heykarthikwithuSure, will work on this :)
Comment #5
tr commentedAlso, your #2 shouldn't be in this patch - the entityTypeManager() should be handled in #2630956: Replace the entity manager with the entity type manager in the code base.
Comment #6
heykarthikwithuChanged all the fully qualified names in the codebase.
Comment #7
heykarthikwithuComment #8
longwaveLooks great. One very minor nitpick:
There should be a blank line between these two lines, but this can be fixed on commit.
Comment #10
longwaveCommitted with the extra blank line added.