Unnessary fully qualified name \Drupal\uc_order\Entity\Order in CheckoutController.php

CommentFileSizeAuthor
#6 interdiff-2630992-2-6.txt19.91 KBheykarthikwithu
#6 2630992-6.patch21.97 KBheykarthikwithu
#2 2630992-2.patch1.39 KBheykarthikwithu

Comments

heykarthikwithu created an issue. See original summary.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: heykarthikwithu » Unassigned
Status: Active » Needs review
StatusFileSize
new 2630992-2.patch1.39 KB

1. Removed unnecessary fully qualified name \Drupal\uc_order\Entity\Order.
2. Replaced the \Drupal::entityManager() with \Drupal::entityTypeManager().

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

I think there are several fully qualified names in the codebase that are not strictly necessary (we should use "use" statements instead), it would be good to get them all at once if you can?

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: Unassigned » heykarthikwithu

Sure, will work on this :)

tr’s picture

tr commented
Status: Needs review » Needs work

Also, your #2 shouldn't be in this patch - the entityTypeManager() should be handled in #2630956: Replace the entity manager with the entity type manager in the code base.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: heykarthikwithu » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 2630992-6.patch21.97 KB
new interdiff-2630992-2-6.txt19.91 KB

Changed all the fully qualified names in the codebase.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Title: Unnessary fully qualified name \Drupal\uc_order\Entity\Order in CheckoutController.php » Unnessary fully qualified name in the codebase.
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: Unnessary fully qualified name in the codebase. » Unnecessary fully qualified names

Looks great. One very minor nitpick:

 namespace Drupal\uc_store\Tests;
+use Drupal\uc_country\Entity\Country;

There should be a blank line between these two lines, but this can be fixed on commit.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Fixed

Committed with the extra blank line added.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.