So in #1240642: Views slideshow js is added in hook_init we introduced a hook_library that would declare the CSS and JS for views slideshow. Sadly, for some reason the patch I supplied there was a bit silly and declared the CSS as being for 'screen' only. This is fine normally, but as soon as you turn on CSS aggregation (most, if not all, sites) then Drupal will have to create two additional aggregate files, one to have the 'screen' only things in it, and another for the other files that are for 'all' and not already aggregated.

Patch to follow.

CommentFileSizeAuthor
#2 views_slideshow-1240642-css-aggregation.patch586 bytessteven jones

Comments

Steven Jones created an issue. See original summary.

steven jones’s picture

steven jones commented
Status: Active » Needs review
StatusFileSize
new views_slideshow-1240642-css-aggregation.patch586 bytes

We can just remove the overrides there, and fall back to the defaults.

steven jones’s picture

steven jones commented
Status: Needs review » Needs work

Hmmm...that didn't work :(

steven jones’s picture

steven jones commented
Status: Needs work » Needs review

Sorry, caching issue :) Yeah that works for me.

jon nunan’s picture

jon nunan commented
Status: Needs review » Reviewed & tested by the community

Fixes the issue for my sites as well. Nice work!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: views_slideshow-1240642-css-aggregation.patch, failed testing.

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Needs work » Reviewed & tested by the community

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Reviewed & tested by the community » Fixed

applied, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.