Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I did a quick review of the code after 8.x-1.0-beta1 release. Thanks for maintaining the module and contributing to D8.
autologout.module
I highly encourage to convert the API functions in to an autologout service. It allows others to override the core of the module without hacking it. And in general play better with D8 architecture.
autologout.api.php
Example code still contains the D7 arg()
function.
AutologoutController.php
Method names do not need to be prefixed with the module name. The class covers the namespace.
autologout.settings.yml
Variable names do need to be prefixed with the module name. The config file covers the name space.
Comments
Comment #2
AjitSThanks a lot for your review and feedback. Will look into the points and work on them individually.
Assigning to myself :)
Comment #3
abhishek-anand CreditAttribution: abhishek-anand at Acquia commentedA pull request had been created to address the above changes.
https://github.com/ajitdev/autologout/pull/18
Comment #4
abhishek-anand CreditAttribution: abhishek-anand at Acquia commentedComment #6
naveenvalechaThe suggested changes has been pushed to the dev branch
Comment #8
AjitSComment #9
AjitS