Necessary before release.
Look at interdiffs in #2603046: Support anonymous users and especially #2469431: BigPipe for auth users: first send+render the cheap parts of the page, then the expensive parts to find which parts need particular testing attention.
Note that to test the BigPipe placeholders that are replaced in JS, we'll need to simulate that without JS, much like we simulate the AJAX system in Drupal core's WebTestBase.
Unless of course we can start using BrowserTestBase soonish…
Test coverage added
- #2671958: SessionExistsCacheContext test coverage
- #2674126: BigPipeResponseAttachmentsProcessor test coverage
- #2674334: BigPipeStrategy test coverage + remaining @todos
- #2674890: BigPipe no-JS detection test coverage (big_pipe_page_attachments() + BigPipeController)
- #2675670: BigPipe response delivery test coverage with JS enabled & disabled (BigPipe + HtmlResponseBigPipeSubscriber)
Comments
Comment #2
wim leersSee #2469713-134: Step 2: Create a JavaScriptTestBase using PhantomJs Driver/Binary.
Comment #3
wim leersThe child issue #2671958: SessionExistsCacheContext test coverage was added and fixed, and adds test coverage for
SessionExistsCacheContext.Comment #4
wim leersComment #5
wim leersComment #6
wim leersComment #7
wim leersComment #8
wim leersComment #9
wim leersThe child issues linked to explicitly from the IS represent the total set of test coverage that is needed. Once all children are fixed, I will close this meta issue.
Comment #10
wim leersAll of the test coverage issues/patches have landed. With the exception of #2675670: BigPipe response delivery test coverage with JS enabled & disabled (BigPipe + HtmlResponseBigPipeSubscriber). I've posted a WIP patch to that issue, and will continue & finish that last one tomorrow. Expect a new core patch at #2469431: BigPipe for auth users: first send+render the cheap parts of the page, then the expensive parts tomorrow!
Comment #11
wim leersAll done!