Being able to change the theme and choosing compressed/raw scripts would be nice addition.

I have a patch coming up for a review.

CommentFileSizeAuthor
#6 enable_ace_editor-2627896-6.patch6.17 KBandeersg
#4 enable_settings-2627896-4.patch5.52 KBosman
#3 enable_settings-2627896-3.patch5.46 KBosman
#2 enable_settings-2627896-2.patch3.54 KBosman

Comments

osman created an issue. See original summary.

osman’s picture

osman
Location Copenhagen
commented
Status: Active » Needs review
StatusFileSize
new enable_settings-2627896-2.patch3.54 KB
osman’s picture

osman
Location Copenhagen
commented
StatusFileSize
new enable_settings-2627896-3.patch5.46 KB
osman’s picture

osman
Location Copenhagen
commented
StatusFileSize
new enable_settings-2627896-4.patch5.52 KB

Forgot the disable grippy. It is not used and IMHO should be removed .

andeersg’s picture

andeersg commented

Hi,

Thank you for your patch, I will take a look at it shortly :)

andeersg’s picture

andeersg commented
StatusFileSize
new enable_ace_editor-2627896-6.patch6.17 KB

Hi,

I have taken a look at your patch now, and I really liked it. I fixed some coding standards and added some t-functions to titles and descriptions.

zaporylie’s picture

zaporylie
he/him
Primary language Polish
commented
Assigned: Unassigned » andeersg
Status: Needs review » Reviewed & tested by the community

LGTM

  • andeersg committed 7d44dca on 7.x-1.x authored by osman 
    Issue #2627896 by osman, andeersg, zaporylie: Enable ACE Editor settings
andeersg’s picture

andeersg commented
Status: Reviewed & tested by the community » Fixed

I committed it to 7.x-1.x now.

osman’s picture

osman
Location Copenhagen
commented

Thanks andeersg.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.