Hi,

Just wanted to have our patch/feature to get reviewed.
Its feature addition so there is an option for the lightbox not to do any redirection and just reload the current page.

I've attached the patch.

This is my first time to contribute, not sure really what happens from here on.

best regards,
LiNo

CommentFileSizeAuthor
#14 patch_noredirection_plus_validation.patch2.73 KBwatda
#4 patch_noredirection.patch1.89 KBwatda
patch_noredirection.txt1.89 KBwatda

Comments

watda created an issue. See original summary.

benjy’s picture

benjy commented
Version: 7.x-1.2 » 7.x-1.x-dev

Could you achieve this by redirecting to the same page?

Also, can you please upload your patches with the .patch file extension, that way they get picked up by the testbot.

benjy’s picture

benjy commented
Status: Needs review » Needs work
watda’s picture

watda commented
StatusFileSize
new patch_noredirection.patch1.89 KB
watda’s picture

watda commented

Hi benjy,

Tried redirection but can't seem to make it work in my case.
Already uploaded a new file in .patch extension.

thanks.

benjy’s picture

benjy commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: patch_noredirection.patch, failed testing.

m_dimitris’s picture

m_dimitris commented

Can I ask smth? The ng_lightbox.module has only 228 lines. Should I add the ng_lightbox_validate(&$form, &$form_state) function?

benjy’s picture

benjy commented

@m_dimistris, sorry I don't know what you mean? I don't think it's relevant to this issue, can you open a new issue.

m_dimitris’s picture

m_dimitris commented

Sorry benjy,
I meant that in the ng_lightbox.module there is no function ng_lightbox_validate(&$form, &$form_state) as stated in the patch_noredirection.patch so that I can change it in order not to make the redirection. Should I add it? Or if I want to make ajax call?

benjy’s picture

benjy commented

Ahh, i see what you mean. That function comes from #2501919: Enable AJAX validation which is another issue. We could work on getting that committed first and then come back here or they @watda, you can submit a patch here that contains both just for testing.

However, I would like to debug why passing the current page to the redirect param doesn't work, feels like it could be masking another issue.

watda’s picture

watda commented

Hi benjy,

Sorry, my bad, this patch needs that one you just mentioned, #2501919: Enable AJAX validation,
Should i submit it there or is it alright to do it here?

cheers,
LiNo

benjy’s picture

benjy commented

You can submit a combination of the two patches here, i'll probably commit the other one shortly.

watda’s picture

watda commented
StatusFileSize
new patch_noredirection_plus_validation.patch2.73 KB
shaneonabike’s picture

shaneonabike commented

Your patch doesn't seem to work and indicates at the end it is corrupted :/