Follow-up to #2552453: Fix test fails on Postgres, SQLite and PHP 7.
Follow-up to #2625664: Name of tables and indexes conflicts for SQLite.
In #2552453: Fix test fails on Postgres, SQLite and PHP 7, we added sqlite specific code, this should be removed when #2625664: Name of tables and indexes conflicts for SQLite lands. We can already attach a patch here.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 2625722-8--remove_sqlite_bug_workaround.patch | 1.66 KB | drunken monkey |
Comments
Comment #2
borisson_Undo the patch added to the database backed in #2552453: Fix test fails on Postgres, SQLite and PHP 7.
Comment #4
borisson_The test failure is correct, it can't apply this patch yet because the original issue not in yet.
Comment #5
nick_vhPostponed until core is fixed
Comment #6
drunken monkeyRe-roll attached.
Also set #2625664: Name of tables and indexes conflicts for SQLite to RTBC, so maybe we can soon finally commit this.
Comment #7
drunken monkeyDoesn't seem like that will happen so soon after all.
However, is there any reason why this is a beta blocker? I don't see any.
Comment #8
drunken monkeyRe-roll (which, irritatingly, already passes tests for me locally?). Core issue is moving again, so maybe this can finally be resolved soon. (Any support in the Core issue appreciated.)