Comments

borisson_ created an issue. See original summary.

borisson_’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new1.67 KB

Undo the patch added to the database backed in #2552453: Fix test fails on Postgres, SQLite and PHP 7.

Status: Needs review » Needs work

The last submitted patch, 2: remove_sqlite_fixing-2625722-2.patch, failed testing.

borisson_’s picture

The test failure is correct, it can't apply this patch yet because the original issue not in yet.

nick_vh’s picture

Status: Needs work » Postponed

Postponed until core is fixed

drunken monkey’s picture

StatusFileSize
new1.63 KB

Re-roll attached.
Also set #2625664: Name of tables and indexes conflicts for SQLite to RTBC, so maybe we can soon finally commit this.

drunken monkey’s picture

Doesn't seem like that will happen so soon after all.
However, is there any reason why this is a beta blocker? I don't see any.

drunken monkey’s picture

StatusFileSize
new1.66 KB

Re-roll (which, irritatingly, already passes tests for me locally?). Core issue is moving again, so maybe this can finally be resolved soon. (Any support in the Core issue appreciated.)