The permission 'administer coupons' is being used as an access argument for a few of the configuration urls, however this is the permission title not the machine name. The permission should be 'administer commerce_coupon entities'.
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | administer_coupons_-2625600-14.patch | 2.19 KB | mglaman |
| #13 | administer_coupons_-2625600-13.patch | 679 bytes | mglaman |
| #10 | administer-coupons-permission-2625600-10.patch | 10.3 KB | eric115 |
| #10 | test-fail-example-2625600-10.patch | 10.3 KB | eric115 |
| #6 | test-fail-example-2625600-6.patch | 3.89 KB | eric115 |
Comments
Comment #2
eric115 commentedPatch attached.
Comment #3
eric115 commentedComment #4
mglamanEric115, great catch. Would you mind writing a test? Post the test that fails, then combine the two to show it passes? If not I can whip up a test. Let me know.
Comment #5
eric115 commented@mglaman, I am happy to write some tests for it. I will upload a new patch with some tests when they are done :)
Comment #6
eric115 commentedHere is an updated patch and an example patch that fails.
Comment #7
eric115 commentedComment #10
eric115 commentedWhoops, bad patch files.
Comment #12
mglamanI like the idea of moving to PSR-4 for tests, but it's making it hard to review. I don't see anywhere in the test a check for "admin/commerce/coupons/types" menu paths to verify permission is goofed.
Comment #13
mglamanI like the idea of moving to PSR-4 for tests, but it's making it hard to review. I don't see anywhere in the test a check for "admin/commerce/coupons/types" menu paths to verify permission is goofed.
Here is a test to test the bad permissions.
Comment #14
mglamanHere is patch from #13 with fix in #2. #13 should fail, this should pass.
Comment #16
mglamanThanks!, committed.