Allow facets to be limited to one active item.

For the checkbox widget, switch output to radios when this option is active

CommentFileSizeAuthor
#15 allow_limiting_to_one-2625188-15.patch6.58 KBborisson_
#15 interdiff.txt1.31 KBborisson_
#13 2625188-13.patch5.27 KBleksat
#7 OneActiveItemFacetapiD7.gif63.67 KBstrykaizer
#6 D7OneItemOnly.gif516.22 KBstrykaizer
#5 allow_limiting_to_one-2625188-5.patch4.35 KBborisson_
#5 interdiff.txt635 bytesborisson_
#2 only-one-active-item.gif40.23 KBborisson_
#2 only-one-active-item--default.gif33.38 KBborisson_
#2 allow_limiting_to_one-2625188-2.patch4.29 KBborisson_

Comments

StryKaizer created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new allow_limiting_to_one-2625188-2.patch4.29 KB
new only-one-active-item--default.gif33.38 KB
new only-one-active-item.gif40.23 KB

Hi @StryKaizer,

I implemented this for the links widget.

Current HEAD behavior:

With patch:

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented

Is this enabled by default? I like this behavior but by no means should it be default. From my experience (not scientific) most sites allow multiple facets to be selected when they are links.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

Disabled by default in the patch.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
StatusFileSize
new interdiff.txt635 bytes
new allow_limiting_to_one-2625188-5.patch4.35 KB

Needed a reroll and some extra changes.

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Version: » 8.x-1.x-dev
StatusFileSize
new D7OneItemOnly.gif516.22 KB

The behaviour in D7 Facetapi is slightly different.
Links do not disappear but instead allow you to switch to another item (So more similar to Radio button-behaviour). I'm in favour of keeping this feature in par with D7.

D7 demo:

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Issue summary: View changes
StatusFileSize
new OneActiveItemFacetapiD7.gif63.67 KB
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Needs work

Does this mean we should postpone on #2625186: Support and/or for facets?

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented

That was my idea too, so, yes? :)

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs work » Postponed
Related issues: +#2625186: Support and/or for facets

postponing this on that.

leksat’s picture

leksat commented

I think we'll need this for #2636328: Widget dropdown - select.

But... Does D7 version work correctly? On #6 gif:
- when nothing is selected, "st" shows 15 results
- when "dr" is selected, "st" shows 9 results
- when then "st" is clicked, "dr" is unselected, and we have 15 results
I think, one-active-item mode should run a separate query if a facet is active, to see how many results we'll have if the active item will be unselected.

Also, I guess that one-active-item mode should be always enabled for the dropdown widget.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Postponed » Needs work

I think this is needed for the dropdown issue, yeah.
Unpostponing this issue because the dependency got in a while ago.

leksat’s picture

leksat commented
Status: Needs work » Needs review
StatusFileSize
new 2625188-13.patch5.27 KB

Made on the base of #5.

The show_only_one_result mode works well only with OR logic. Should we implement some form validation that prevents AND logic with show_only_one_result? Or it's up to user?

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Needs work

I think that form validation makes sense and implementing that is a good idea. This will also need an extra testcase in the integration test.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.31 KB
new allow_limiting_to_one-2625188-15.patch6.58 KB

Added an integration test.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Fixed

I fixed a small code style thing on commit and pushed this.

  • borisson_ committed bf7f3be on 8.x-1.x 
    Issue #2625188 by borisson_, Leksat, StryKaizer: Allow limiting to one...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.