I found some issues with the menu callback that handles calls from the nodejs application. I have been trying to fix these,but it's still not fully functional. I found the following.

- routing.yml format is outdated
- NodejsPages class, which handles the message handler callback (/nodejs/message) should be in the .../Controller namespace
- there was call to drupal_json_decode in NodejsPages class
- In D7, the nodejs_service_key variable was configurable in the node_config submodule, but was used in the main module to validate calls. However, this approach does not work anymore because the two modules' settings are stored in different configuration realms. I propose we add the nodejs_service_key setting to the main module's config form.

I'm including a patch for these. Let me know your thoughts.

CommentFileSizeAuthor
#2 message-handler-2625084-2.patch5.71 KBglekli

Comments

Gergely Lekli created an issue. See original summary.

glekli’s picture

StatusFileSize
new5.71 KB
Anonymous’s picture

Status: Needs review » Reviewed & tested by the community

looks good, thanks for the patch.

i've given you push access to the repository, go ahead and commit it.

glekli’s picture

Status: Reviewed & tested by the community » Fixed

Perfect, thank you. This fix has been committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.