I found some issues with the menu callback that handles calls from the nodejs application. I have been trying to fix these,but it's still not fully functional. I found the following.
- routing.yml format is outdated
- NodejsPages class, which handles the message handler callback (/nodejs/message) should be in the .../Controller namespace
- there was call to drupal_json_decode in NodejsPages class
- In D7, the nodejs_service_key variable was configurable in the node_config submodule, but was used in the main module to validate calls. However, this approach does not work anymore because the two modules' settings are stored in different configuration realms. I propose we add the nodejs_service_key setting to the main module's config form.
I'm including a patch for these. Let me know your thoughts.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | message-handler-2625084-2.patch | 5.71 KB | glekli |
Comments
Comment #2
glekli commentedComment #3
Anonymous (not verified) commentedlooks good, thanks for the patch.
i've given you push access to the repository, go ahead and commit it.
Comment #5
glekli commentedPerfect, thank you. This fix has been committed.