Having an element would allow us to use entity browser outside of the field api with more easily.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | interdiff.txt | 14.36 KB | slashrsm |
| #10 | 2624874_10.patch | 34.48 KB | slashrsm |
| #8 | 2624874_8.patch | 32.43 KB | slashrsm |
| #7 | 2624874_7.patch | 31.93 KB | slashrsm |
| #6 | 2624874_6.patch | 17.09 KB | slashrsm |
Comments
Comment #2
primsi commentedComment #3
primsi commentedStill a work in progress: https://github.com/drupal-media/entity_browser/pull/118
I am not sure about what to do with the field widget display. Adding that to the element would mean
Comment #4
slashrsm commentedPR: https://github.com/drupal-media/entity_browser/pull/118/files
Comment #5
slashrsm commentedComment #6
slashrsm commentedBased on PR that @Primsi started. Few modifications and added a test.
Comment #7
slashrsm commentedReady for review.
Comment #8
slashrsm commentedReroll after #2763505: Move file_entity and file_browser's Field Widget for Files and Images to Entity Browser.
Comment #9
samuel.mortenson1.
"
$widget->getThirdPartySetting('entity_browser_entity_form', 'entity_browser_id')" is called three times in this function - can we call it once at the top of the function?2.
This sort of routine is used a couple of times, I feel like individual functions shouldn't have to process
$form_values['entity_browser']['entity_ids'], it would be nice if they all just called a utility function like_entity_browser_process_enity_ids(string or array). It's also worth noting that the current implementation only works for one Entity Type, even though each entity ID contains an Entity Type.3.
Cardinality is a WidgetValidation plugin now - do we ever need to explicitly support it as a unique setting? This might be worth filing a new issue to track and refactor all instances of cardinality.
4.
Will we need to make the same change in the FileBrowserWidget Field Widget?
Comment #10
slashrsm commentedFixed all items from #9. I think I found all parts of code that are related to #9.3. It would probably make sense to also support #entity_types limit. I guess this can be a follow-up, since we need to update validator too (to support multiple types).
Also changed order of arguments in
DisplayInterface::displayEntityBrowser()to follow core pattern.Comment #12
slashrsm commentedCommitted. Created a follow-up in entity embed: #2767573: [Follow-up] Use Entity browser's form element
Comment #14
gábor hojtsy