Hello,

Inside the admin form definition, an item_list() is called with a class attribute passed as a string instead of an array:

 theme('item_list', array(
      'items' => array(
        t('Add <em>[node:title]</em> to your favorites'),
        t('Add this [node:type] to your favorites'),
        t('Vote for this proposal ([node:flag-vote-count] people have already done so)'),
      ),
      'attributes' => array('class' => 'token-examples'),
    )) .

The 'class' key inside the attributes should rather be an array so any preprocessing of theme_item_list() can safely add classes to all list items if needed. Otherwise, you get errors or you need to do string handling. Maybe worth fixing real quick in your next iteration.

CommentFileSizeAuthor
#3 2624602-3.patch722 bytesupchuk

Comments

Upchuk created an issue. See original summary.

joachim’s picture

Sounds reasonable. Any chance you could make a patch for that?

upchuk’s picture

Status: Active » Needs review
StatusFileSize
new722 bytes

Sure, here you go :)

D

joachim’s picture

Status: Needs review » Fixed

Thanks! Committed.

  • joachim committed 5e4a943 on 7.x-3.x authored by Upchuk
    Issue #2624602 by Upchuk: Changed attributes passed to theme_item_list...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.