Closed (outdated)
Project:
Drupal 8 Contrib Porting Tracker
Version:
8.x-0.x-dev
Component:
Module
Priority:
Normal
Category:
Plan
Assigned:
Unassigned
Reporter:
Created:
27 Nov 2015 at 20:12 UTC
Updated:
1 Sep 2025 at 22:40 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
capuleto commentedComment #3
fl3a commentedChange code link to sandbox.
Comment #4
MaskyS commentedComment #5
mmjvb commentedWith only a sandbox Status should be Needs work. Needs review means having an alpha or beta release on d.o. A sandbox qualifies as a development release. You need a maintainer to judge the quality and adding it to the project.
Comment #6
MaskyS commentedComment #7
MaskyS commentedI inspected the initial port by capuleto and it was of really good quality. There were just a few files missing and had to delete one D7 file. Later on, I decided to test the module. That's when I noticed that, the user cannot use all the display methods at once, and if the user changed the display method, ALL Gists throughout the site would be rendered that way. This is really unflexible, and means that if you wanted a gist link in one article and an embedded gist in another, you couldn't do it. So I rewrote the process() function and removed the 'choose a display method' part.
The module/filter now replaces three tags:
- [gist:xx] is replaced and a fully embedded gist is displayed. (embed method was chosen as the '[gistembed:xx]' tag would have been too long, and the embed method is likely the most used one.)
- [gistcode:xx] is replaced by just the contents(code) of the gist, can come up handy when you are explaining a file little by little.
- [gistlink:xx] is replaced by the link to the gist. This way, the user can use all three display methods simultaneously on their website without any issues. I have attached a screenshot demonstrating this.
Comment #8
mmjvb commented@Kifah Meeran Please use the issue queue of the project itself to document this. This issue is only about the port and will be closed upon completion. Your information will be lost for most once the port is finished. At the project itself you can also request assistance for getting your sandbox applied to the project.
Comment #9
avpadernoThe sandbox no longer exists and the project does not have any Drupal 8+ releases.
Comment #10
avpadernoThe project does not have releases for supported Drupal versions.