# Summary

Gist Filter

# Project URL

https://www.drupal.org/project/gist_filter

# Where is the code?

http://cgit.drupalcode.org/sandbox-MaskyS-2931287

# Estimated completion date

January 2018

# Dependencies

Unknown

# Who's doing the port?

https://www.drupal.org/u/capuleto
https://www.drupal.org/u/kifah-meeran

# What help do they need?

Review

# D8 roadmap

Unknown

# Background and reference information

capuleto did much of the work in his initial port, which you can see on his sandbox here: https://www.drupal.org/sandbox/fl3a/2819998
I (kifah-meeran) am finishing what he started with some final touches and a rework of the module's functionality (Refer to comment #5 below.)

CommentFileSizeAuthor
#7 DeepinScreenshot_20171216170912.png358.14 KBMaskyS

Comments

capuleto created an issue. See original summary.

capuleto’s picture

Title: [gist_filter] Gist Filter » [gist_filter] Gist Input Filter
Assigned: Unassigned » capuleto
Status: Needs review » Needs work
fl3a’s picture

Issue summary: View changes

Change code link to sandbox.

MaskyS’s picture

Assigned: capuleto » MaskyS
Issue summary: View changes
Status: Needs work » Needs review
mmjvb’s picture

Status: Needs review » Needs work

With only a sandbox Status should be Needs work. Needs review means having an alpha or beta release on d.o. A sandbox qualifies as a development release. You need a maintainer to judge the quality and adding it to the project.

MaskyS’s picture

Issue summary: View changes
MaskyS’s picture

StatusFileSize
new358.14 KB

I inspected the initial port by capuleto and it was of really good quality. There were just a few files missing and had to delete one D7 file. Later on, I decided to test the module. That's when I noticed that, the user cannot use all the display methods at once, and if the user changed the display method, ALL Gists throughout the site would be rendered that way. This is really unflexible, and means that if you wanted a gist link in one article and an embedded gist in another, you couldn't do it. So I rewrote the process() function and removed the 'choose a display method' part.

The module/filter now replaces three tags:
- [gist:xx] is replaced and a fully embedded gist is displayed. (embed method was chosen as the '[gistembed:xx]' tag would have been too long, and the embed method is likely the most used one.)

- [gistcode:xx] is replaced by just the contents(code) of the gist, can come up handy when you are explaining a file little by little.

- [gistlink:xx] is replaced by the link to the gist. This way, the user can use all three display methods simultaneously on their website without any issues. I have attached a screenshot demonstrating this.

mmjvb’s picture

@Kifah Meeran Please use the issue queue of the project itself to document this. This issue is only about the port and will be closed upon completion. Your information will be lost for most once the port is finished. At the project itself you can also request assistance for getting your sandbox applied to the project.

avpaderno’s picture

Assigned: MaskyS » Unassigned
Status: Needs work » Active

The sandbox no longer exists and the project does not have any Drupal 8+ releases.

avpaderno’s picture

Status: Active » Closed (outdated)

The project does not have releases for supported Drupal versions.