The "created" field type provided by Drupal core is cool, it has timestamp formatter and other functions, and can simplify the views field settings.

CommentFileSizeAuthor
#15 2624224-interdiff.txt4.06 KBlongwave
#8 2624224-created-and-changed-field-8.patch20.37 KBjian he
#8 interdiff.txt1.16 KBjian he
#6 2624224-created-and-changed-field-6.patch20.37 KBjian he
#6 interdiff.txt3.74 KBjian he
#5 2624224-created-and-changed-field-5.patch16.62 KBjian he
#5 interdiff.txt13.73 KBjian he
#3 interdiff.txt2.89 KBjian he
#3 2624224-created-field-3.patch3.84 KBjian he
#2 2624224-created-field.patch973 bytesjian he
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jian he created an issue. See original summary.

jian he’s picture

jian he CreditAttribution: jian he commented
Status: Active » Needs review
FileSize
2624224-created-field.patch973 bytes
jian he’s picture

jian he CreditAttribution: jian he commented
FileSize
2624224-created-field-3.patch3.84 KB
interdiff.txt2.89 KB

let views created field using the standard field plugin.

TR’s picture

TR CreditAttribution: TR commented
Status: Needs review » Needs work

That's a good idea. That field type didn't exist when we first ported Ubercart to D8.

We should probably also use the 'changed' field for the order modified time and for the cart item entity modified time.

uc_order.tokens.inc needs to be fixed in the patch too.

Don't worry about the created/modified times in uc_reports - that is all being replaced by Views so there's no need to work on what we currently have (which is broken anyway).

jian he’s picture

jian he CreditAttribution: jian he commented
Title: Change order's created field type from integer to created » Change created and changed field to correct field type.
FileSize
interdiff.txt13.73 KB
2624224-created-and-changed-field-5.patch16.62 KB

Rename the modified field to changed, and change the field type from integer to changed.
Will doing field for CartItem soon.

jian he’s picture

jian he CreditAttribution: jian he commented
Status: Needs work » Needs review
FileSize
interdiff.txt3.74 KB
2624224-created-and-changed-field-6.patch20.37 KB

Change the changed field type for CartItem from integer to changed.

Status: Needs review » Needs work

The last submitted patch, 6: 2624224-created-and-changed-field-6.patch, failed testing.

jian he’s picture

jian he CreditAttribution: jian he commented
FileSize
interdiff.txt1.16 KB
2624224-created-and-changed-field-8.patch20.37 KB

Fixed the testing issue: Unknown or bad timezone.

jian he’s picture

jian he CreditAttribution: jian he commented
Status: Needs work » Needs review
jian he’s picture

jian he CreditAttribution: jian he commented

The last submitted patch, 5: 2624224-created-and-changed-field-5.patch, failed testing.

The last submitted patch, 6: 2624224-created-and-changed-field-6.patch, failed testing.

jian he’s picture

jian he CreditAttribution: jian he commented

OK it passed :)

  • longwave committed 4126853 on 8.x-4.x authored by jian he 
    Issue #2624224 by jian he, longwave: Change created and changed field to...
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented
Status: Needs review » Fixed
FileSize
2624224-interdiff.txt4.06 KB

Thanks! Committed with no functional changes but some minor fixes to comments, whitespace and formatting, see attached interdiff for details.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.